1429313 - reuse |nextColIndex| to reduce unnecessary calls

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement)

Description

[Ya-Chieh Wu (inactive)]

Attachment: 0001-reduce-unnecessary-calls.patch

We can reuse |nextColIndex|[1] for the function below because we wouldn't change |info|'s colIndex in that function. 


https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/layout/tables/nsTableFrame.cpp#6460

Comment 1

[Ya-Chieh Wu (inactive)]

triage a try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca8b1b161e2907d688fe87f607da615bf1ddbac3

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8941347 [details] [diff] [review]
0001-reduce-unnecessary-calls.patch

Review of attachment 8941347 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: You'll need to add the bug number to the commit title. 

Also, "reduce unnecessary calls" is not clear to me. How about something like: "Reuse nextColIndex to avoid extra BCMapCellInfo::GetCellEndRowIndex() calls"?

Comment 3

[Ya-Chieh Wu (inactive)]

Attachment: 0001-Bug-1429313-Reuse-nextColIndex-to-avoid-extra-BCMapC.patch

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #2) 
> Nit: You'll need to add the bug number to the commit title. 
> 
> Also, "reduce unnecessary calls" is not clear to me. How about something
> like: "Reuse nextColIndex to avoid extra BCMapCellInfo::GetCellEndRowIndex()
> calls"?

done. thx!

Comment 4

[Ya-Chieh Wu (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5006ed7cedacf73cacc8e20e04561deff3fd2d07

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b62099b50fc7
Reuse nextColIndex to avoid extra BCMapCellInfo::GetCellEndRowIndex() calls. r=tylin

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b62099b50fc7