1429322 - Show credit card logos in credit card autofill UI

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Lauren Fu(Firefox EPM)]

As users, I would like to see credit card logos when using credit card autofill. The logos should display in those 2 scenarios and the credit card logo should match the exact type.

scenario 1:
credit card logo in drop-down menu

scenario 2:
credit card logo in profile editing page

Comment 1

[Lauren Fu(Firefox EPM)]

Can you please to provide UX spec for showing credit card logo ? Thanks.

Comment 2

[Mark Liang(:mark_liang)]

Added card logos in the UX spec: https://mozilla.invisionapp.com/share/4JC69R77D
Check out the page here: https://mozilla.invisionapp.com/share/NSFA82V7K#/272884642_2-5_Credit_Card_Logo

Comment 3

[Lauren Fu(Firefox EPM)]

Hi Liz, we are the engineering team for form autofill project and we'd like to land this bug for showing credit card logos on 3 scenarios (add one more extra scenarios after actual spec coming out from UX) in credit card autofill feature. 3 scenarios are described as below. Can you help to access if it's OK to let this bug land on Fx59 ? Please let me you if any question. Thanks.

P.S For now we are still waiting for the permission to use those logos and not yet developed this bug. Once it's OK for you then I will discuss with Ovidiu, our QA, about adding extra test plan for this bug. 

scenario 1:
credit card logo in drop-down menu
https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/228658333

scenario 2:
credit card logo in profile editing page
https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/215538005

scenario 3:
credit card logo in doorhanger
https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/264871692

various credit card logos we will use:
https://mozilla.invisionapp.com/share/7ZA4WEK9W#/screens/272884642

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Ovidiu, would it be difficult to add this to your existing test plan for form autofill for beta 59?

Comment 5

[ovidiu boca[:Ovidiu]]

Hello Liz,

What can we do in this situation is to talk with the beta testing team to include this test cases in their test run for the beta 59. 
From QA point of view and based on the fact that this credit card logo feature is not yet developed, it will be better to include this in the form autofill version 3 and let it ride the Fx-60 trains. In this case, the development team will have time to fully implement this feature and in case that there will be bugs will have time to fix them and we will be able to verify them.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Let's plan for 60 then. 
But, if we test and verify in 60, and the changes look good, we can think about uplifting during early beta 59. I don't think we can promise it.

Comment 7

[Adam Roach [:abr]]

Attachment: Bug 1429322: Add credit card logos to the autofill UI r=zbraniecki

Comment 8

[Adam Roach [:abr]]

From MattN (Bug 1392520 comment 14):

The logos look horizontally squished in that screenshot (unlike what I see in about:preferences) so I think they are likely to reject that screenshot. Can you play with the aspect-ratio CSS properties so that proportions are maintained?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de87e5707f58
Add credit card logos to the autofill UI r=zbraniecki

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/de87e5707f58

Comment 11

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Attachment: Save_Update credit card logo issue.png

Hi,

While trying to verify this, I noticed that in the scenario 3 from comment 3, the credit card logo is not displayed in the doorhanger. Is that expected?
For scenario 1 and 2 the credit card logo is displayed accordingly. Verified in Beta 79.0b1 and latest Nightly 80.0a1 (2020-06-29) using Windows 10.

Thanks.

Comment 12

[Adam Roach [:abr]]

(In reply to Alin Ilea from comment #11)

While trying to verify this, I noticed that in the scenario 3 from comment 3, the credit card logo is not displayed in the doorhanger. Is that expected?

I don't find a bug open for this, but I assume it's something we want? Tagging Holly for UX spec.

Comment 13

[[e-mail]]

Yes, it's ok that the doorhanger doesn't show a specific logo.

Comment 14

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Verified - Fixed in Beta 79.0b1 and latest Nightly 80.0a1 (2020-06-30) using Windows 10 (see screenshots in comment 11).
Thanks for the reply.