1429329 - Move some inner classes of MDSM to its own namespace

Status: NEW

(Core :: Audio/Video: Playback, enhancement, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

To make Eclipse C++ indexer happy so callers can be found correctly.

Comment 1

[Jean-Yves Avenard [:jya]]

I thought the coding style stated we were not to use namespace unless absolutely necessary:

"C++ namespaces. Mozilla project C++ declarations should be in the "mozilla" namespace. Modules should avoid adding nested namespaces under "mozilla" unless they are meant to contain names which have a high probability of colliding with other names in the code base (e.g., Point , Path , etc.)."

A better solution for this problem would be to stop using eclipse which is awful anyway

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Any good alternatives?

Comment 3

[Jean-Yves Avenard [:jya]]

I like Visual Studio Code, use on all platforms now.

Name resolutions works perfectly if you generate a CompileDB database (./mach build-backend -b CompileDB) and set the created json in the c_cpp_properties.json

I can help you set it up on IRC.

Comment 4

[Tzuhao Kuo [:kaku]]

Not really related to this bug, but have you ever considered to separate those state class into isolated files?

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

It looks live MSC doesn't support finding callers of a function which is heavily used by me.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.