1429365 - network-monitor.js, line 527: TypeError: this.sink is null

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

Go to https://en.wikipedia.org/wiki/Main_Page

Open developer tools to the console
Open Scratchpad
Paste in this code:

```

document.location.reload()


```

Hit Ctrl-R to run the code a few times.

Look at the terminal:
JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/shared/webconsole/network-monitor.js, line 527: TypeError: this.sink is null

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

I wasn't able to see the 'this.sink is null', but I saw the following error:

JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/shared/webconsole/network-monitor.js, line 458: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.contentCharset]


@Ricky, can you try to repro this bug?

Honza

Comment 2

[magicp]

I can reproduce this bug.

Steps to reproduce:
1. Launch Nightly
2. Open Browser Console (Ctrl+Shift+J)
3. Enable Responsive Design Mode (Ctrl+Shift+M)
4. Change network throttling to "DSL"
5. Go to "https://www.mozilla.org"
6. Reload current page a few times (Ctrl+R)

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Hmm... interesting. I'm sure I saw ` TypeError: this.sink is null` randomly in past but I cannot reproduce it locally now.

I believe this issue is reported properly but we need to find out the solid STR to reproduce it.


On the other hand, I'm seeing the following error spraying out unusually on terminal when visiting https://edition.cnn.com/ .

JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js, line 1647: TypeError: can't access dead object
JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js, line 1647: TypeError: can't access dead object
JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js, line 1647: TypeError: can't access dead object

Comment 4

[Ricky Chien [:rickychien] (inactive)]

I'm suffering this kind of trashing error messages regularly, which is really annoying.  I will keep watching this issue and find out the right STR. If you have new findings, please comment below. Thanks for reporting the issue.

Comment 5

[magicp]

Finding regression range is complicated by other errors, but I think below. Because, this error disappear with my str if "dom.script_loader.bytecode_cache.enabled = false"

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=62cd3bf2db56339a60b7af5e54cf01fd80549ece&tochange=ec038106d24cdfc01a6c99cf78e8f349018e11ff

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Alex, do you have any idea of this? (please see comment 5)

Comment 7

[Ricky Chien [:rickychien] (inactive)]

For can't access dead object error, please see bug 1409705

Comment 8

[Alexandre Poirot [:ochameau]]

This is a regression from bug 1372115. It looks like there is a race in netmonitor actor for files fetched from bytecode cache.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1429365 - Prevent this.sink is undefined exception for resources loaded from bytecode cache.

Review commit: https://reviewboard.mozilla.org/r/212918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212918/

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8942669 [details]
Bug 1429365 - Prevent this.sink is undefined exception for resources loaded from bytecode cache.

https://reviewboard.mozilla.org/r/212918/#review218696

Thank you Alex, this patch looks great to me and this.sink is undefined exception has gone away.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffe766bd6f33
Prevent this.sink is undefined exception for resources loaded from bytecode cache. r=rickychien

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ffe766bd6f33