contentScripts.register runAt option should be set to document_idle when missing

RESOLVED FIXED in Firefox 60

Status

defect
P3
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

unspecified
mozilla60
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
The runAt option is currently marked as optional:

- https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/toolkit/components/extensions/schemas/content_scripts.json#72-76

but it doesn't currently defaults to "document_idle", as it is done for the content scripts registered from the manifest.json file, and so the following error is logged:

'runAt' member of WebExtensionContentScriptInit 'null' is not a valid value for enumeration ContentScriptRunAt.
Assignee

Updated

a year ago
Summary: contentScripts.register runAt option should default to document_idle when missing → contentScripts.register runAt option should be set to document_idle when missing

Updated

a year ago
Priority: -- → P3
Assignee

Updated

a year ago
Attachment #8947198 - Flags: review?(mixedpuppy)

Comment 2

a year ago
mozreview-review
Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222844
Attachment #8947198 - Flags: review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222986
Attachment #8947198 - Flags: review?(mixedpuppy) → review+

Comment 4

a year ago
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/0e0273e2fb91
contentScripts.register runAt option should be set to document_idle when missing. r=mixedpuppy,zombie

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0e0273e2fb91
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Updated

a year ago
Flags: qe-verify-

Updated

11 months ago
Product: Toolkit → WebExtensions
Assignee: nobody → lgreco
You need to log in before you can comment on or make changes to this bug.