Closed Bug 1429425 Opened 3 years ago Closed 3 years ago

contentScripts.register runAt option should be set to document_idle when missing

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: rpl, Assigned: rpl)

Details

Attachments

(1 file)

The runAt option is currently marked as optional:

- https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/toolkit/components/extensions/schemas/content_scripts.json#72-76

but it doesn't currently defaults to "document_idle", as it is done for the content scripts registered from the manifest.json file, and so the following error is logged:

'runAt' member of WebExtensionContentScriptInit 'null' is not a valid value for enumeration ContentScriptRunAt.
Summary: contentScripts.register runAt option should default to document_idle when missing → contentScripts.register runAt option should be set to document_idle when missing
Priority: -- → P3
Attachment #8947198 - Flags: review?(mixedpuppy)
Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222844
Attachment #8947198 - Flags: review+
Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222986
Attachment #8947198 - Flags: review?(mixedpuppy) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/0e0273e2fb91
contentScripts.register runAt option should be set to document_idle when missing. r=mixedpuppy,zombie
https://hg.mozilla.org/mozilla-central/rev/0e0273e2fb91
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Flags: qe-verify-
Product: Toolkit → WebExtensions
Assignee: nobody → lgreco
You need to log in before you can comment on or make changes to this bug.