1429425 - contentScripts.register runAt option should be set to document_idle when missing

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The runAt option is currently marked as optional:

- https://searchfox.org/mozilla-central/rev/03877052c151a8f062eea177f684a2743cd7b1d5/toolkit/components/extensions/schemas/content_scripts.json#72-76

but it doesn't currently defaults to "document_idle", as it is done for the content scripts registered from the manifest.json file, and so the following error is logged:

'runAt' member of WebExtensionContentScriptInit 'null' is not a valid value for enumeration ContentScriptRunAt.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

Review commit: https://reviewboard.mozilla.org/r/216966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216966/

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222844

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8947198 [details]
Bug 1429425 - contentScripts.register runAt option should be set to document_idle when missing.

https://reviewboard.mozilla.org/r/216966/#review222986

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e0273e2fb91
contentScripts.register runAt option should be set to document_idle when missing. r=mixedpuppy,zombie

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0e0273e2fb91