Closed Bug 1429426 Opened 2 years ago Closed 2 years ago

Crash in nsNSSSocketInfo::SetNPNList

Categories

(Core :: Networking: HTTP, defect, P1, critical)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: marcia, Assigned: dragana)

References

Details

(Keywords: crash, regression, Whiteboard: [necko-triaged])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-bea969d6-d6d4-4698-8cbb-bf1900180103.
=============================================================

Seen while looking at crash stats - crashes started using 20171222100407: http://bit.ly/2CWXbvk. Although low volume, there are still users hitting it up in builds from the last few days. TFO was turned on 12/21 so I am not sure if that comes into play or not in this crash.

Top 10 frames of crashing thread:

0 xul.dll nsNSSSocketInfo::SetNPNList security/manager/ssl/nsNSSIOLayer.cpp:618
1 xul.dll mozilla::net::nsHttpConnection::SetupNPNList netwerk/protocol/http/nsHttpConnection.cpp:811
2 xul.dll mozilla::net::nsHttpConnection::InitSSLParams netwerk/protocol/http/nsHttpConnection.cpp:940
3 xul.dll mozilla::net::nsHttpConnection::SetupSSL netwerk/protocol/http/nsHttpConnection.cpp:769
4 xul.dll mozilla::net::nsHttpConnection::Activate netwerk/protocol/http/nsHttpConnection.cpp:685
5 xul.dll mozilla::net::nsHttpConnectionMgr::DispatchAbstractTransaction netwerk/protocol/http/nsHttpConnectionMgr.cpp:1771
6 xul.dll mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::SetupConn netwerk/protocol/http/nsHttpConnectionMgr.cpp:4773
7 xul.dll mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::StartFastOpen netwerk/protocol/http/nsHttpConnectionMgr.cpp:4429
8 xul.dll mozilla::net::nsSocketTransport::InitiateSocket netwerk/base/nsSocketTransport2.cpp:1540
9 xul.dll mozilla::net::nsSocketTransport::OnSocketEvent netwerk/base/nsSocketTransport2.cpp:2096

=============================================================
Dragana, does this seem TFO related?
Flags: needinfo?(dd.mozilla)
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(dd.mozilla)
Priority: -- → P1
Whiteboard: [necko-triaged]
In bug 1422895 I removed check:

if (GetModuleHandleW(L"pmls64.dll") || GetModuleHandleW(L"rlls64.dll")) {	
      mFastOpenSupported = false;	
}

I thought that such crashes were a side effect of another bug and they accidentally have these dll in it.

Obviously they are not, I will add the check again.
Attachment #8941795 - Flags: review?(valentin.gosu)
Attachment #8941795 - Flags: review?(valentin.gosu) → review+
Pushed by dd.mozilla@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5fb2e369165
Disable TFO if pmls64.dll and rlls64.dll are detected. r=valentin
Crash Signature: [@ nsNSSSocketInfo::SetNPNList] → [@ nsNSSSocketInfo::SetNPNList] [@ SSL_SetNextProtoNego | rlls64.dll@0x72bf5] [@ SSL_SetNextProtoNego | pmls64.dll@0x72bf5] [@ SSL_SetNextProtoNego | pmls64.dll@0x74381] [@ @0x0 | SSL_SetNextProtoNego | pmls64.dll@0x74381] [@ SSL_SetNextProtoNego | p…
Duplicate of this bug: 1428603
https://hg.mozilla.org/mozilla-central/rev/e5fb2e369165
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
See Also: → 1394550
You need to log in before you can comment on or make changes to this bug.