1429426 - Crash in nsNSSSocketInfo::SetNPNList

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-bea969d6-d6d4-4698-8cbb-bf1900180103.
=============================================================

Seen while looking at crash stats - crashes started using 20171222100407: http://bit.ly/2CWXbvk. Although low volume, there are still users hitting it up in builds from the last few days. TFO was turned on 12/21 so I am not sure if that comes into play or not in this crash.

Top 10 frames of crashing thread:

0 xul.dll nsNSSSocketInfo::SetNPNList security/manager/ssl/nsNSSIOLayer.cpp:618
1 xul.dll mozilla::net::nsHttpConnection::SetupNPNList netwerk/protocol/http/nsHttpConnection.cpp:811
2 xul.dll mozilla::net::nsHttpConnection::InitSSLParams netwerk/protocol/http/nsHttpConnection.cpp:940
3 xul.dll mozilla::net::nsHttpConnection::SetupSSL netwerk/protocol/http/nsHttpConnection.cpp:769
4 xul.dll mozilla::net::nsHttpConnection::Activate netwerk/protocol/http/nsHttpConnection.cpp:685
5 xul.dll mozilla::net::nsHttpConnectionMgr::DispatchAbstractTransaction netwerk/protocol/http/nsHttpConnectionMgr.cpp:1771
6 xul.dll mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::SetupConn netwerk/protocol/http/nsHttpConnectionMgr.cpp:4773
7 xul.dll mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::StartFastOpen netwerk/protocol/http/nsHttpConnectionMgr.cpp:4429
8 xul.dll mozilla::net::nsSocketTransport::InitiateSocket netwerk/base/nsSocketTransport2.cpp:1540
9 xul.dll mozilla::net::nsSocketTransport::OnSocketEvent netwerk/base/nsSocketTransport2.cpp:2096

=============================================================

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Dragana, does this seem TFO related?

Comment 2

[Marcia Knous [:marcia]]

It looks as if reports such as https://crash-stats.mozilla.com/report/index/d5a7bc88-fc7d-42c3-8e3c-920720171227 have this stack as well.

Comment 3

[Dragana Damjanovic [:dragana]]

In bug 1422895 I removed check:

if (GetModuleHandleW(L"pmls64.dll") || GetModuleHandleW(L"rlls64.dll")) {	
      mFastOpenSupported = false;	
}

I thought that such crashes were a side effect of another bug and they accidentally have these dll in it.

Obviously they are not, I will add the check again.

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: bug_1429426.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5fb2e369165
Disable TFO if pmls64.dll and rlls64.dll are detected. r=valentin

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e5fb2e369165