1429449 - Dropdown menu shouldn't handle non-primary button click

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement, P1)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:
  1. have some notification
  2. click requests icon next to avatar
  3. click the menu item with secondary mouse button

Actual result:
  the dropdown menu closes

Expected result:
  the dropdown menu keeps opened and context menu is opened for the element under the mouse cursor

https://github.com/mozilla-bteam/bmo/blob/4104df0c3e48105a95f163cd9e8bec40b87a8854/js/dropdown.js#L11-L17
https://github.com/mozilla-bteam/bmo/blob/4104df0c3e48105a95f163cd9e8bec40b87a8854/js/dropdown.js#L102-L103

those event handlers should check the 'e.button' and ignore the event if it's non-zero (non-primary)

the same issue happen for other dropdowns, like "New/Clone Bug" menu at the bottom of bug page.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

I'm working on fixing some layout issues, I'll get to this next -- or maybe someone wants it as a good first bug.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Do not handle non-primary click on dropdown menu.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8941460 [details] [review]
Do not handle non-primary click on dropdown menu.

thanks! You're a returning contributor of course. :-)