1429467 - ChooseScaleAndSetTransform does not take incoming scale in to account when choosing scale for animation

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jamie Nicol [:jnicol]]

In FrameLayerBuilder, ChooseScaleAndSetTransform does not take the incoming scale in to account when calling nsLayoutUtils::ComputeSuitableScaleForAnimation. So while this prevents individual transforms from creating a layer too large, nested transforms each with a small scale can add up and result in huge layers.

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1429467 - Take ancestors' scales in to account when choosing scale for animations.

Currently ChooseScaleAndSetTransform calls
ComputeDesiredDisplaySizeForAnimation to ensure that the scale chosen
for an individual transform's animation does not result in a layer too
large. However, it does not take in to account the scale chosen for
ancestors. This means that when lots of containers with reasonable
scales are nested we end up with too large a value. This change takes
the incoming scale in to account, meaning the resulting layer size is
capped appropriately.

Review commit: https://reviewboard.mozilla.org/r/211762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211762/

Comment 2

[Jamie Nicol [:jnicol]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b86a1daccc6410de7a6a2b6d492410066d9d1e26

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8941485 [details]
Bug 1429467 - Take ancestors' scales in to account when choosing scale for animations.

https://reviewboard.mozilla.org/r/211762/#review217680

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c026dda65eb
Take ancestors' scales in to account when choosing scale for animations. r=mattwoodrow

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4c026dda65eb