Closed Bug 1429467 Opened 2 years ago Closed 2 years ago

ChooseScaleAndSetTransform does not take incoming scale in to account when choosing scale for animation

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

Details

Attachments

(1 file)

In FrameLayerBuilder, ChooseScaleAndSetTransform does not take the incoming scale in to account when calling nsLayoutUtils::ComputeSuitableScaleForAnimation. So while this prevents individual transforms from creating a layer too large, nested transforms each with a small scale can add up and result in huge layers.
Comment on attachment 8941485 [details]
Bug 1429467 - Take ancestors' scales in to account when choosing scale for animations.

https://reviewboard.mozilla.org/r/211762/#review217680
Attachment #8941485 - Flags: review?(matt.woodrow) → review+
Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c026dda65eb
Take ancestors' scales in to account when choosing scale for animations. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/4c026dda65eb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.