1429529 - stylo: Merge lazy pseudo style cache into anonymous box style cache

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Bobby Holley (:bholley)]

+++ This bug was initially created as a clone of Bug #1401449 +++

See bug 1401449 comment 14.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89f807f3ae12323e6dd15dac7455b48e5daa0606

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 1 - Bug 1429529 - Rename CachedAnonBoxStyles to CachedInheritingStyles. v1

MozReview-Commit-ID: xgZbalAJ5x

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 2 - Use the same cache for lazy pseudos and anonymous boxes. v1

MozReview-Commit-ID: FaSK8RAlrW2

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8941572 [details] [diff] [review]
Part 2 - Use the same cache for lazy pseudos and anonymous boxes. v1

Review of attachment 8941572 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: servo/ports/geckolib/tests/size_of.rs
@@ +31,5 @@
>  // selectors (with the inline hashes) with as few cache misses as possible.
>  size_of_test!(test_size_of_rule, style::stylist::Rule, 32);
>  
>  // Large pages generate tens of thousands of ComputedValues.
> +size_of_test!(test_size_of_cv, ComputedValues, 248);

nice :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85f9b85ae324
Rename CachedAnonBoxStyles to CachedInheritingStyles. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ea45022c163e
Use the same cache for lazy pseudos and anonymous boxes. r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/85f9b85ae324
https://hg.mozilla.org/mozilla-central/rev/ea45022c163e