stylo: Merge lazy pseudo style cache into anonymous box style cache

RESOLVED FIXED in Firefox 59

Status

()

P4
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1401449 +++

See bug 1401449 comment 14.
(Assignee)

Updated

a year ago
Depends on: 1429126
No longer depends on: 1401449
(Assignee)

Comment 2

a year ago
MozReview-Commit-ID: xgZbalAJ5x
Attachment #8941571 - Flags: review?(emilio)
(Assignee)

Comment 3

a year ago
MozReview-Commit-ID: FaSK8RAlrW2
Attachment #8941572 - Flags: review?(emilio)
Attachment #8941571 - Flags: review?(emilio) → review+
Comment on attachment 8941572 [details] [diff] [review]
Part 2 - Use the same cache for lazy pseudos and anonymous boxes. v1

Review of attachment 8941572 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: servo/ports/geckolib/tests/size_of.rs
@@ +31,5 @@
>  // selectors (with the inline hashes) with as few cache misses as possible.
>  size_of_test!(test_size_of_rule, style::stylist::Rule, 32);
>  
>  // Large pages generate tens of thousands of ComputedValues.
> +size_of_test!(test_size_of_cv, ComputedValues, 248);

nice :)
Attachment #8941572 - Flags: review?(emilio) → review+

Comment 5

a year ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85f9b85ae324
Rename CachedAnonBoxStyles to CachedInheritingStyles. r=emilio
https://hg.mozilla.org/integration/autoland/rev/ea45022c163e
Use the same cache for lazy pseudos and anonymous boxes. r=emilio

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85f9b85ae324
https://hg.mozilla.org/mozilla-central/rev/ea45022c163e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
status-firefox57: --- → wontfix
status-firefox58: --- → wontfix
You need to log in before you can comment on or make changes to this bug.