Closed Bug 1429568 Opened 6 years ago Closed 6 years ago

Unexpected Passes and Easy Fuzzy Bumps in WR windows CI

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox59 --- affected

People

(Reporter: Gankra, Assigned: kats)

References

Details

Attachments

(2 files)

There's a bunch of unexpected passes (probably "less fuzzy than the minimum bound") and a bunch of fails which can very reasonably just be fuzzed away.
Attached file fuzzier.txt
Here's the ones I indentified as clearly fine to bump the fuzz on:
Attached file passes.txt
Here's the ones I identified as unexpectedly and reasonably passing. Some are still a bit fuzzy and just need the lower-bound dropped.
Oh! One thing to keep in mind is that my windows try pushes (such as the one above) include a tweak to the reftest harness that effectively does fuzzy-if(webrender,2,infinity) on all the tests. See patch at [1]. I did this because otherwise there a lot more failures. However for actually getting the reftests greened up we will want to not do this hack. This hack is also responsible for some of the unexpected-pass results that show up.

[1] https://hg.mozilla.org/try/rev/28b2e036e822ed0f3e30e96f7c8854aae6e30a5c
Assignee: nobody → a.beingessner
Priority: -- → P1
kats did what could be done here, nothing more to do.
Assignee: a.beingessner → bugmail
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: