1429605 - Simplify rect.Inflate(someLength, someLength) calls to use single-param version

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P5)

Description

[Daniel Holbert [:dholbert]]

BaseRect has a convenience "Inflate()" method that takes a single arg and then calls the 2-arg version:

>  void Inflate(T aD) { Inflate(aD, aD); }
>  void Inflate(T aDx, T aDy)
>  {
>    x -= aDx;
>    y -= aDy;
>    width += 2 * aDx;
>    height += 2 * aDy;
>  }
https://dxr.mozilla.org/mozilla-central/rev/c38d22170d6f27e94c3c53093215d20255fab27a/gfx/2d/BaseRect.h#267

So any call of the form...
  r.Inflate(foo, foo);
...could really be simplified to just:
  r.Inflate(foo);

Filing this bug to do cleanup of this sort.  I found one place in the code in nsMathMLChar::PaintVertically while doing a code-review in bug 1424382:
>  unionRect.Inflate(oneDevPixel, oneDevPixel);
https://dxr.mozilla.org/mozilla-central/rev/c38d22170d6f27e94c3c53093215d20255fab27a/layout/mathml/nsMathMLChar.cpp#2209

...but I assume there are more.

Comment 1

[u480271]

Attachment: Use single-param version of rect.Inflate when x == y. r?dholbert

MozReview-Commit-ID: BP8Vm6eL0zg

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8970423 [details] [diff] [review]
Use single-param version of rect.Inflate when x == y. r?dholbert

Review of attachment 8970423 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kamidphish, could you have a look please?

Comment 4

[u480271]

Attachment: Bug 1429605 - Use single-param version of rect.Inflate when x == y.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e2f12439dca
Use single-param version of rect.Inflate when x == y. r=dholbert

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5e2f12439dca

Comment 7

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/5e2f12439dca9c25f6f42245be8c7929a1ce66aa
Bug 1429605 - Use single-param version of rect.Inflate when x == y. r=dholbert