Closed Bug 1429671 Opened 2 years ago Closed 2 years ago

Accept null values for composite member of Keyframe dictionary objects

Categories

(Core :: DOM: Animation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: birtles, Assigned: birtles)

Details

Attachments

(1 file)

This bug tracks the code/test changes corresponding to the following spec changes:

  https://github.com/w3c/csswg-drafts/commit/abf76745b50c8943e8b16c13abc61cb6ca814830

Issue: https://github.com/w3c/csswg-drafts/issues/2074
(Oh no. When I ran `./mach clang-format -s` to see what it would change, not only did it look at *all* the code in dom/animation as opposed to only the changed code, it also ignored the '-s' option and actually changed *all* the code in dom/animation. I hope I don't miss something important when I try to extract the functional changes from the cosmetic ones.)
Summary: Accept null values for Keyframe composite member → Accept null values for composite member of Keyframe dictionary objects
Comment on attachment 8941747 [details]
Bug 1429671 - Make composite member of Keyframe dictionary objects accept null values;

https://reviewboard.mozilla.org/r/211982/#review217882
Attachment #8941747 - Flags: review?(bzbarsky) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/91211b85310e
Make composite member of Keyframe dictionary objects accept null values; r=bz
https://hg.mozilla.org/mozilla-central/rev/91211b85310e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.