Closed
Bug 1429701
Opened 8 years ago
Closed 8 years ago
Enable ESLint rule mozilla/use-services for dom/indexedDB
Categories
(Core :: Storage: IndexedDB, enhancement, P2)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
As we've been doing elsewhere, this continues the work to replace .getService() with Services.jsm uses where possible and enable the mozilla/use-services rule, this has small gains in performance (less boundary crossing) and generally more easy to read code.
For dom/indexedDB, this just affects test files.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8941763 [details]
Bug 1429701 - Enable ESLint rule mozilla/use-services for dom/indexedDB.
There's currently failures showing up on try. I'm investigating what's best to do here.
Attachment #8941763 -
Flags: review?(btseng)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941763 [details]
Bug 1429701 - Enable ESLint rule mozilla/use-services for dom/indexedDB.
https://reviewboard.mozilla.org/r/212008/#review218050
Looks good to me, thanks!
Attachment #8941763 -
Flags: review?(btseng) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/698ae46fa634
Enable ESLint rule mozilla/use-services for dom/indexedDB. r=bevis
|
||
Updated•8 years ago
|
Priority: -- → P2
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•