1429703 - Identify the form fields again in start search stage.

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

Some web sites use `autofocus` on an input, and `identifyAutofillFields` method will be called even JS code in the page is still appending fields.

The dropdown can show and fill a form, but the same behavior will be broken when clicking on another field.

If a form is changed for adding or removing a field after focusing event, the issue can be reproduced.

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1429703 - Identify the form fields in "startSearch" again to make sure the form states are up to date.

Review commit: https://reviewboard.mozilla.org/r/212030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212030/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8941778 [details]
Bug 1429703 - Identify the form fields in "startSearch" again to make sure the form states are up to date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212030/diff/1-2/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8941778 [details]
Bug 1429703 - Identify the form fields in "startSearch" again to make sure the form states are up to date.

https://reviewboard.mozilla.org/r/212030/#review219220

Looks good. Thanks.

::: commit-message-4db16:1
(Diff revision 2)
> +Bug 1429703 - Identify the form fields to make sure the state is updated. r=lchang

nit: I'd like to make the comment a bit clearer like `Identify the form fields in "startSearch" again to make sure the form states are up to date`

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8941778 [details]
Bug 1429703 - Identify the form fields in "startSearch" again to make sure the form states are up to date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212030/diff/2-3/

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8941778 [details]
Bug 1429703 - Identify the form fields in "startSearch" again to make sure the form states are up to date.

https://reviewboard.mozilla.org/r/212030/#review219220

> nit: I'd like to make the comment a bit clearer like `Identify the form fields in "startSearch" again to make sure the form states are up to date`

Thanks. The comment is updated.

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfcaa4c280ac9a7408bb30fb07feb04f7cb0ba25
Talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=88bcb857fb9a8b6c0873ea69d137d71ea56b984c&newProject=try&newRevision=8c32376b743a255b691f59685ebead51b742248f&framework=1