Closed Bug 1429812 Opened 2 years ago Closed 6 months ago

Investigate MSVC's Return Flow Guard

Categories

(Core :: Security, enhancement)

enhancement
Not set

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox59 --- affected

People

(Reporter: tjr, Unassigned)

References

Details

/guard:rf

Literally brand new in 15.5.3 so no one knows what it does or how it works. MSFT will release more information eventually, I just don't want to forget about it.
Perf results are in: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=cd0d24d4447b42c9bf013d3b65940dfad746246f&framework=1&selectedTimeRange=172800

It's pretty sizable regressions all across the board. Except for stylebench for some weird reason.
See Also: → 1465859

Reminder to self; this isn't going to be useful unless platform libs are compiled with it....

Do you expect clang to implement this at some point? If it's strictly MSVC-only then it's pretty much wontfix at this point.

(In reply to David Major [:dmajor] from comment #4)

Do you expect clang to implement this at some point? If it's strictly MSVC-only then it's pretty much wontfix at this point.

Hard to guess. For reference, CFG : CFI :: RFG :: Bug 1465859 (which they removed.)

We should probably just close this out rather than leave it pending an unknown situation. I'm sure that if clang does end up doing something similar, we'll be quick to open a bug (or revisit this one) as soon as we hear about it.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.