Scrollbars not showing in window.open popups, if sites pass the option `scrollbars=no` (i.e. consider removing support for `scrollbars=no`)

NEW
Unassigned

Status

()

defect
P3
normal
2 years ago
Last month

People

(Reporter: deep.bkp007, Unassigned)

Tracking

({nightly-community, parity-chrome, regression})

57 Branch
Points:
---

Firefox Tracking Flags

(Webcompat Priority:?)

Details

()

Attachments

(4 attachments)

Reporter

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce:

Open website :https://cboxera.com/cbox.html
click on register button.
check the popup registration page.


Actual results:

after clicking register button a pop-up registration page will open which is not completely full and will show half of the page with no scroll bar , even page footer , registration button is getting cut, but the page is working fine in chrome.. Interestingly the page works fine in firefox incognito mode.

Tried to reset firefox,reinstalled firefox,deleted all addons..Result is same.


Expected results:

It should had a scrollbar.
Reporter

Updated

2 years ago
Severity: normal → major
OS: Unspecified → Windows 10
Priority: -- → P3
Reporter

Updated

2 years ago
Version: unspecified → 57 Branch

Comment 1

2 years ago
[Tracking Requested - why for this release]:

As per STR in comment0, I tried to reproduce. Pop-up doesn't open in new window as in attachment 8941956 [details]. Clicking on register loads register.html in same tab both in normal and private window. Full page is rendered with scrolling.

@Deep_Saha can you update and try it once and tell here?
Con can also try with clean profile to overcome it

Browser: Firefox Nightly 59.0a1  [Build ID:20180114100259]
         Firefox Quantum 58.0b16 [Build ID:20180111124119]

OS: Windows 10.0 X 64-bit
[bugday-20170108]
Flags: needinfo?(deep.bkp007)
Reporter

Comment 2

2 years ago
see the video..

I tried to reinstall also firefox still same issue , I dont know what is causing this..

https://youtu.be/BhG5L6whUCc
Flags: needinfo?(deep.bkp007)
Reporter

Comment 3

2 years ago
check the 2nd video in this link for detailed troubleshooting and error showing (7mins long)...

I uninstalled firefox , cleaned leftover files and registry using "Revo Uninstaller Pro" and 
manually by visiting ( Program Files / Program Files (x86) / App Data - Roaming - Local etc..) 
Then again manually searched for registry using "Registry Finder" , and removed all leftover files.
Reinstalled firefox using the official website, then opened the link and same error in both normal and incognito.
also shown you the same page in chrome with no error and valid scrollbar..


Please check this video for all the mentioned above steps...

New Link Detailed : 

https://www.youtube.com/watch?v=1AoHZoTvQg4&feature=youtu.be
Reporter

Comment 4

2 years ago
Same Problem in different versions tried just now again using same process above..


Browser: Firefox Nightly 59.0a1  
         Firefox Quantum 58.0b16
         Firefox Quantum 57.0.4

All above browser produced the same result.

P.S Video is bit blurry , made using less frame and quality to make the video smaller in size for upload.
Hi, the website owner has explicitly disabled scrollbars for that popup window.

https://developer.mozilla.org/en-US/docs/Web/API/Window/open
Ctrl+F: scrollbars
Reporter

Comment 6

2 years ago
if he deliberately disabled scrollbars for that popup window then why its working fine in chrome .. you can see the 2nd video which I shown in the last that its working fine with scrollbar in chrome..

Its not possible he deliberately disabled scrollbars in firefox and works fine in chrome or internet explorer and edge.
Searching for the last build where one is able to scroll in a scrollbars=no javascript popup:

mozregression --good 2016-02-01 --bad 2018-01-11 --pref startup.homepage_welcome_url:"https://cboxera.com/cbox.html"
> 7:27.36 INFO: Last good revision: 9c5d494d05485aebf3fedf649abc0e7ae9d2dcf2 (2016-03-19)
> 7:27.36 INFO: First bad revision: f14898695ee0dd14615914f3e1401f17df57fdd7 (2016-03-20)
> 7:27.36 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9c5d494d05485aebf3fedf649abc0e7ae9d2dcf2&tochange=f14898695ee0dd14615914f3e1401f17df57fdd7
(...Unable to find build info using the taskcluster route...)

probably bug 1229220 "[e10s] window.scrollbars.visible is not false when window is opened with scrollbars=no"

mozregression --launch 2016-03-19 --pref startup.homepage_welcome_url:"https://cboxera.com/cbox.html"
scrolling is possible

Summary:
* bug 1229220 fixed a bug and made sure that there is really no scrollbar when a website says scrollbars=no
* bug 1257887 made the default that a javascript popup has scrollbars by default, so websites don't need to opt-in with scrollbars=yes.
It also removed the pref dom.disable_window_open_feature.scrollbars which I don't understand at the moment (I'm not a Firefox dev). But it seems that a website can still opt-out from scrollbars with scrollbars=no.

Your bug is more or less about "enforce scrollbars=yes in javascript popups", I think.
Those two bugs are in Core: DOM, so I move this bug over there.
I confirm that Chromium ignores scrollbars=0 and shows a scrollbar, which is user-friendly. So this may be something for [parity-Chrome].
Severity: major → normal
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Component: Untriaged → DOM
Ever confirmed: true
Keywords: 64bit
OS: Windows 10 → All
Priority: P3 → --
Product: Firefox → Core
Hardware: Unspecified → All
See Also: → 1229220, 1257887
Summary: Scrollbar Not Showing in Few Pages → Scrollbar Not Showing in Few Pages (please enforce scrollbars=yes in javascript popups)
Whiteboard: [parity-Chrome]
Comment hidden (offtopic)
Comment hidden (obsolete)
Comment hidden (offtopic)
Comment hidden (offtopic)
Comment hidden (offtopic)
@Firefox Devs:
https://support.mozilla.org/de/questions/1066799
This problem also affects browser.link.open_newwindow.restriction;0 (open popups as tabs).
Such a popup tab doesn't have a scrollbar (because of scrollbars=0).
If you copy the popup url (https://cboxera.com/register.html) into a new tab, you will have a scrollbar.
Reporter

Comment 14

2 years ago
thanks a lot... :)
Ben, you worked on bug 1257887. Please take a look here.
Flags: needinfo?(btian)
Flags: needinfo?(ben.tian)
Flags: needinfo?(overholt)
Flags: needinfo?(overholt)
Priority: -- → P3
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome
Whiteboard: [parity-Chrome]

Comment 17

4 months ago

I faced same issue mentioned here. 2 sites where I miss the vertical scrollbars

https://creditreport.paisabazaar.com/bureau/user-profile
https://mynation.net/

I can provide screenshots too.

Comment 18

4 months ago

Can someone who knows how to code try to fix this. I don't really understand what the current code does.

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/windowwatcher/nsWindowWatcher.cpp

Current code:

1698  // default scrollbar to "on," unless explicitly turned off
1699  bool scrollbarsPresent = false;
1700  if (WinHasOption(aFeatures, "scrollbars", 1, &scrollbarsPresent) ||
1701      !scrollbarsPresent) {
1702    chromeFlags |= nsIWebBrowserChrome::CHROME_SCROLLBARS;
1703  }
1704  presenceFlag = presenceFlag || scrollbarsPresent;
1705
1706  return chromeFlags;
1707}

Do we just need this??

1698  // force scrollbar=on
1699  chromeFlags |= nsIWebBrowserChrome::CHROME_SCROLLBARS;
1700
1701  return chromeFlags;
1702}
Component: DOM → DOM: Core & HTML
Duplicate of this bug: 1542753

[editing bug summary for searchability, to mention window.open and scrollbars=no, and removing some stale/useless version flags]

Also: I don't know this particular area of code, but it looks to me like comment 18 is likely the right fix here.

Webcompat Priority: --- → ?
Summary: Scrollbar Not Showing in Few Pages (please enforce scrollbars=yes in javascript popups) → Scrollbars not showing in window.open popups, if sites pass the option `scrollbars=no` (i.e. consider removing support for `scrollbars=no`)
You need to log in before you can comment on or make changes to this bug.