Closed
Bug 1429979
Opened 6 years ago
Closed 6 years ago
Some clean up for ImageLoader
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(3 files)
While modifying ImageLoader for shape-outside: <image>, I found some part of ImageLoadder can benefit from new hash table APIs or C++ features. Patches are coming.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=16eea9f2892da8dec5742fa1950ad6eb3c193ada
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8942039 [details] Bug 1429979 Part 1 - Use LookupForAdd() to avoid explicit new nsAutoPtr. https://reviewboard.mozilla.org/r/212248/#review218056
Attachment #8942039 -
Flags: review?(cam) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8942040 [details] Bug 1429979 Part 2 - Use ranged-based for loop to iterate FrameSet. https://reviewboard.mozilla.org/r/212250/#review218058
Attachment #8942040 -
Flags: review?(cam) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8942041 [details] Bug 1429979 Part 3 - Use nsClassHashtable::Get() which directly returns the value. https://reviewboard.mozilla.org/r/212252/#review218062
Attachment #8942041 -
Flags: review?(cam) → review+
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fc44817e833 Part 1 - Use LookupForAdd() to avoid explicit new nsAutoPtr. r=heycam https://hg.mozilla.org/integration/autoland/rev/0cef7b376e37 Part 2 - Use ranged-based for loop to iterate FrameSet. r=heycam https://hg.mozilla.org/integration/autoland/rev/4a9f600f5658 Part 3 - Use nsClassHashtable::Get() which directly returns the value. r=heycam
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fc44817e833 https://hg.mozilla.org/mozilla-central/rev/0cef7b376e37 https://hg.mozilla.org/mozilla-central/rev/4a9f600f5658
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•