1429979 - Some clean up for ImageLoader

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

While modifying ImageLoader for shape-outside: <image>, I found some part of ImageLoadder can benefit from new hash table APIs or C++ features. Patches are coming.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1429979 Part 1 - Use LookupForAdd() to avoid explicit new nsAutoPtr.

Review commit: https://reviewboard.mozilla.org/r/212248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212248/

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1429979 Part 2 - Use ranged-based for loop to iterate FrameSet.

Review commit: https://reviewboard.mozilla.org/r/212250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212250/

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1429979 Part 3 - Use nsClassHashtable::Get() which directly returns the value.

Review commit: https://reviewboard.mozilla.org/r/212252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212252/

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=16eea9f2892da8dec5742fa1950ad6eb3c193ada

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8942039 [details]
Bug 1429979 Part 1 - Use LookupForAdd() to avoid explicit new nsAutoPtr.

https://reviewboard.mozilla.org/r/212248/#review218056

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8942040 [details]
Bug 1429979 Part 2 - Use ranged-based for loop to iterate FrameSet.

https://reviewboard.mozilla.org/r/212250/#review218058

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8942041 [details]
Bug 1429979 Part 3 - Use nsClassHashtable::Get() which directly returns the value.

https://reviewboard.mozilla.org/r/212252/#review218062

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fc44817e833
Part 1 - Use LookupForAdd() to avoid explicit new nsAutoPtr. r=heycam
https://hg.mozilla.org/integration/autoland/rev/0cef7b376e37
Part 2 - Use ranged-based for loop to iterate FrameSet. r=heycam
https://hg.mozilla.org/integration/autoland/rev/4a9f600f5658
Part 3 - Use nsClassHashtable::Get() which directly returns the value. r=heycam

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5fc44817e833
https://hg.mozilla.org/mozilla-central/rev/0cef7b376e37
https://hg.mozilla.org/mozilla-central/rev/4a9f600f5658