1429986 - Add a telemetry to evaluate popularity of the Matroska

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Alfredo Yang (:alfredo)]

As title, from bug 1422891

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: Bug 1429986 - send telemetry data when users attempt to play mkv file.

Review commit: https://reviewboard.mozilla.org/r/212310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212310/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8942085 [details]
Bug 1429986 - send telemetry data when users attempt to play mkv file.

https://reviewboard.mozilla.org/r/212310/#review218096

::: dom/media/DecoderTraits.cpp:155
(Diff revision 1)
>  
>    if (DecoderTraits::IsHttpLiveStreamingType(aType)) {
>      Telemetry::Accumulate(Telemetry::MEDIA_HLS_CANPLAY_REQUESTED, true);
>    }
>  
> +  if (DecoderTraits::IsMatroskaType(aType)) {

else if (...) to be more efficient.

Comment 3

[Tim Langhorst]

Is there any possibility to also collect cases, where normally incompatible for format like opus and h264 are played together via Javascript? This would mark the need of something, that can do that combos without JavaScript.

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Tim Langhorst from comment #3)
> Is there any possibility to also collect cases, where normally incompatible
> for format like opus and h264 are played together via Javascript? This would
> mark the need of something, that can do that combos without JavaScript.

It needs matroska parser which we don't have now.

Comment 5

[Tim Langhorst]

(In reply to Alfredo Yang (:alfredo) from comment #4)
> (In reply to Tim Langhorst from comment #3)
> > Is there any possibility to also collect cases, where normally incompatible
> > for format like opus and h264 are played together via Javascript? This would
> > mark the need of something, that can do that combos without JavaScript.
> 
> It needs matroska parser which we don't have now.

Well, if I understand it correctly javascript players like shaka player just control and demux it, but decoding is still done by the browser, so if a tab plays eg. opus or vorbis with eg. h264 it should be detectable

Comment 6

[Chenxia Liu [:liuche]]

Hi JW, can you fill out this data review form as a comment? That way we can document why this telemetry is being collected.

https://github.com/mozilla/data-review/blob/master/request.md

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8942085 [details]
Bug 1429986 - send telemetry data when users attempt to play mkv file.

Please flag me for review after the form is filled out. If you include the form before flagging a data peer for review, they can probably approve the review immediately.

Comment 8

[Alfredo Yang (:alfredo)]

# Request for data collection review form

**All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.**

1) What questions will you answer with this data?
=> The popularity of Matroska video/audio format.

2) Why does Mozilla need to answer these questions?  Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
=> Users are asking Firefox to support Matroska in bug 1422891. Before we make a decision, we need to know the popularity of this format.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
=> No, we don't know other ways.

4) Can current instrumentation answer these questions?
=> Yes

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox [data c](https://wiki.mozilla.org/Firefox/Data_Collection)[ollection ](https://wiki.mozilla.org/Firefox/Data_Collection)[categories](https://wiki.mozilla.org/Firefox/Data_Collection) on the found on the Mozilla wiki.   
=> Category 1 “Technical data”

6) How long will this data be collected?  Choose one of the following:
=> This is scoped to a time-limited experiment/project until Firefox 65.

7) What populations will you measure?
* Which release channels?
=> release version
* Which countries?
* Which locales?
=> global

8) Please provide a general description of how you will analyze this data.
=> To count how many people use Matroska to play audio/video on web, so we'd make a decision in bug 1422891.

9) Where do you intend to share the results of your analysis?
=> We will discuss the result in bug 1422891.

Comment 9

[Chenxia Liu [:liuche]]

> Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples). Refer to the appendix for "documentation" if more detail about documentation standards is needed.

Yes, in Histograms

> Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, Firefox data controls

> If the request is for permanent data collection, is there someone who will monitor the data over time?**
Expires in 65, ayang

> Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 2

> Is the data collection request for default-on or default-off?
default on

> Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

> Is the data collection covered by the existing Firefox privacy notice?

Yes

> Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Expires in 65

Comment 10

[Chenxia Liu [:liuche]]

Comment on attachment 8942085 [details]
Bug 1429986 - send telemetry data when users attempt to play mkv file.

https://reviewboard.mozilla.org/r/212310/#review219462

data-review only, r+

Comment 11

[Alfredo Yang (:alfredo)]

Comment on attachment 8942085 [details]
Bug 1429986 - send telemetry data when users attempt to play mkv file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212310/diff/1-2/

Comment 12

[Alfredo Yang (:alfredo)]

(In reply to Chenxia Liu [:liuche] - not actively working on Fennec from comment #10)
> Comment on attachment 8942085 [details]
> Bug 1429986 - send telemetry data when users attempt to play mkv file.
> 
> https://reviewboard.mozilla.org/r/212310/#review219462
> 
> data-review only, r+

thank you!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c6d55c85948
send telemetry data when users attempt to play mkv file. r=jwwang,liuche

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4c6d55c85948

Comment 15

[Tim Langhorst]

The number of requests (beta) are currently 1.13M (nightly: 64.56k), with roughly between 20K and 80K (nightly: 500 to 1K) requests per day (I'm not sure what "sample count" is, but it's around 130K/day (nightly: 2K/day)).

Would that be sufficient? (I don't think it'll change too much)

Beta:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=False%2520percentage!True%2520percentage!Invalid%2520value%2520percentage&cumulative=1&end_date=2018-10-01&include_spill=0&keys=!__none__!__none__&max_channel_version=beta%252F63&measure=MEDIA_MKV_CANPLAY_REQUESTED&min_channel_version=beta%252F60&processType=*&product=Firefox!Fennec&sanitize=1&sort_keys=submissions&start_date=2018-09-04&trim=1&use_submission_date=0

Nightly:
https://telemetry.mozilla.org/new-pipeline/evo.html#!aggregates=False%2520percentage!True%2520percentage!Invalid%2520value%2520percentage&cumulative=0&end_date=2018-10-02&include_spill=0&keys=!__none__!__none__&max_channel_version=nightly%252F64&measure=MEDIA_MKV_CANPLAY_REQUESTED&min_channel_version=nightly%252F61&processType=*&product=Firefox!Fennec&sanitize=1&sort_keys=submissions&start_date=2018-09-04&trim=1&use_submission_date=0