Closed Bug 1430037 Opened 3 years ago Closed 3 years ago

Use sparse checkouts for docker image builds

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla59

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8942124 [details]
Bug 1430037 - Use sparse checkouts for docker image builds.

https://reviewboard.mozilla.org/r/212388/#review218918
Attachment #8942124 - Flags: review?(dustin) → review+
Comment on attachment 8942123 [details]
Bug 1430037 - Use the in-tree image builder image to build docker images.

https://reviewboard.mozilla.org/r/212386/#review218912

This is a great idea :)

::: taskcluster/taskgraph/transforms/docker_image.py:154
(Diff revision 1)
>              },
>          }
>  
> +        worker = taskdesc['worker']
> +
> +        if image_name == 'image_builder':

A comment here might be good
Attachment #8942123 - Flags: review?(dustin) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/800640c0dc3f
Use the in-tree image builder image to build docker images. r=dustin
https://hg.mozilla.org/integration/autoland/rev/8b80471c1d79
Use sparse checkouts for docker image builds. r=dustin
Blocks: fastci
Depends on: 1430958
Comment on attachment 8942123 [details]
Bug 1430037 - Use the in-tree image builder image to build docker images.

I made a change that avoids this change to propagate to other branches at land time.
Attachment #8942123 - Flags: review+ → review?(dustin)
Comment on attachment 8942123 [details]
Bug 1430037 - Use the in-tree image builder image to build docker images.

https://reviewboard.mozilla.org/r/212386/#review219394
Attachment #8942123 - Flags: review?(dustin) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1227e2800bd8
Use the in-tree image builder image to build docker images. r=dustin
https://hg.mozilla.org/integration/autoland/rev/63351f0612b4
Use sparse checkouts for docker image builds. r=dustin
https://hg.mozilla.org/mozilla-central/rev/1227e2800bd8
https://hg.mozilla.org/mozilla-central/rev/63351f0612b4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/b68fd8f127d1
Port Bug 1430037: Use the in-tree image builder image to build docker images; rs=bustage-fix
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.