Closed Bug 1430123 Opened 2 years ago Closed 2 years ago

Add vendor capability for old PointerMove behavior

Categories

(Testing :: geckodriver, enhancement, P2)

Version 3
enhancement

Tracking

(firefox58 unaffected, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Bug 1393831 changed the way how we calculate the default position for elements to match the WebDriver spec. Basically it changed it from top/left to the in center view point.

Given that this causes problems for some Selenium bindings, we need a fallback and as agreed via a vendor capability.

With Maja we agreed on `moz:useNonSpecCompliantPointerOrigin`.

As we wondered it might be good if geckodriver just could pass through all of those vendor capabilities, so that we don't have to release a new geckodriver version each time.
Marking as P2 to allow a fallback for users who have to rely on the old (non webdriver spec) behavior.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #8943559 - Flags: review?(ato)
Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

The code change looks good, but I have a question.

::: testing/geckodriver/README.md:297
(Diff revision 1)
> +Please note that this capability exists only temporarily, and that it will be
> +removed once all vendors updated their existent drivers to match the [WebDriver]
> +specification.

I thought the migration path was for the Selenium clients to update
their shims?
Attachment #8943559 - Flags: review?(ato) → review-
Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

> I thought the migration path was for the Selenium clients to update
> their shims?

Oh yes, basically for us! But other vendors also have to update their drivers. So we should include both.
Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219674
Attachment #8943559 - Flags: review?(ato) → review+
Comment on attachment 8943559 [details]
Bug 1430123 - Add vendor capability for old Pointer Origin behavior.

https://reviewboard.mozilla.org/r/213910/#review219658

> Oh yes, basically for us! But other vendors also have to update their drivers. So we should include both.

Well, lets remove other vendors. We don't actually care about that, when the bindings handle our new behavior correctly.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d97649d30062
Add vendor capability for old Pointer Origin behavior. r=ato
https://hg.mozilla.org/mozilla-central/rev/d97649d30062
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.