1430152 - Move Rust mozversion crate from GitHub to central

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

As with https://bugzil.la/1429511 we want to move the Rust
mozversion crate from GitHub [1] to central.  We will follow the
same approach outlined in that bug.

  [1] https://github.com/jgraham/mozversion

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1430152 - Move Rust port of mozversion to central.

This moves the Rust crate mozrunner into central from GitHub.
The old repository will be graveyarded:

	https://github.com/jgraham/mozversion

The git history is not considered important, hence this does not
overlay that onto central like we did for testing/geckodriver and
testing/webdriver.

Review commit: https://reviewboard.mozilla.org/r/212494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212494/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1430152 - Move geckodriver to in-tree mozversion.

Review commit: https://reviewboard.mozilla.org/r/212496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212496/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212494/diff/1-2/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942221 [details]
Bug 1430152 - Move geckodriver to in-tree mozversion.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212496/diff/1-2/

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8942221 [details]
Bug 1430152 - Move geckodriver to in-tree mozversion.

https://reviewboard.mozilla.org/r/212496/#review218234

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

https://reviewboard.mozilla.org/r/212494/#review218558

::: testing/mozbase/rust/mozversion/.hgignore:2
(Diff revision 2)
> +target
> +Cargo.lock

I don't know about git, but I'm pretty sure that hg won't pick up this file. You could add these rules to the toplevel .hgignore/.gitignore files if it's important though (prefixed to testing/mozbase/rust of course).

Either way these ignore files should probably be removed.

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

https://reviewboard.mozilla.org/r/212494/#review218558

> I don't know about git, but I'm pretty sure that hg won't pick up this file. You could add these rules to the toplevel .hgignore/.gitignore files if it's important though (prefixed to testing/mozbase/rust of course).
> 
> Either way these ignore files should probably be removed.

Thanks for pointing this out!  I’ve made the changes to topsrcdir’s
.hgignore file.

It is fine to leave the testing/mozbase/rust/mozversion/.gitignore
file as these are automatically picked up in git.

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942220 [details]
Bug 1430152 - Move Rust port of mozversion to central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212494/diff/2-3/

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942221 [details]
Bug 1430152 - Move geckodriver to in-tree mozversion.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212496/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/777ee4ac78e4
Move Rust port of mozversion to central. r=ahal
https://hg.mozilla.org/integration/autoland/rev/878662b94ba2
Move geckodriver to in-tree mozversion. r=jgraham

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/777ee4ac78e4
https://hg.mozilla.org/mozilla-central/rev/878662b94ba2