Closed
Bug 1430157
Opened 6 years ago
Closed 6 years ago
Move Rust mozprofile crate from GitHub to central
Categories
(Testing :: Mozbase, enhancement)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(2 files)
As with https://bugzil.la/1429511 and https://bugzil.la/1430152 we want to move the Rust mozprofile create from GitHub [1] to central. We will follow the same procedure outlined in in the mozrunner bug. [1] https://github.com/jgraham/rust_mozprofile
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
Actually we need to land mozrunner first because it uses mozprofile as a development dependency, and cargo is not too happy about having two different versions of mozprofile in the same program.
Depends on: 1429511
Assignee | ||
Updated•6 years ago
|
Attachment #8942229 -
Flags: review?(ahalberstadt)
Attachment #8942230 -
Flags: review?(james)
Comment 4•6 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #3) > Actually we need to land mozrunner first because it uses mozprofile > as a development dependency, and cargo is not too happy about having > two different versions of mozprofile in the same program. This has been done. Andreas, can you update the patch so that we can get this bug fixed?
Flags: needinfo?(ato)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(ato)
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8942229 [details] Bug 1430157 - Move Rust port of mozprofile to central. https://reviewboard.mozilla.org/r/212510/#review224576 ::: testing/mozbase/rust/mozprofile/.hgignore:1 (Diff revision 2) > +target Remove these ignore files (you already added rules to the root .hgignore/.gitignore when doing the previous imports).
Attachment #8942229 -
Flags: review?(ahalberstadt) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8942230 [details] Bug 1430157 - Move geckodriver to use in-tree mozprofile. https://reviewboard.mozilla.org/r/212512/#review224596
Attachment #8942230 -
Flags: review?(james) → review+
Assignee | ||
Comment 9•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8942229 [details] Bug 1430157 - Move Rust port of mozprofile to central. https://reviewboard.mozilla.org/r/212510/#review224576 > Remove these ignore files (you already added rules to the root .hgignore/.gitignore when doing the previous imports). Ah, thanks for reminding me!
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•6 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6e62f28bb60 Move Rust port of mozprofile to central. r=ahal https://hg.mozilla.org/integration/autoland/rev/eb0ddcf7bf57 Move geckodriver to use in-tree mozprofile. r=jgraham
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d6e62f28bb60 https://hg.mozilla.org/mozilla-central/rev/eb0ddcf7bf57
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•