1430157 - Move Rust mozprofile crate from GitHub to central

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

As with https://bugzil.la/1429511 and https://bugzil.la/1430152 we
want to move the Rust mozprofile create from GitHub [1] to central.
We will follow the same procedure outlined in in the mozrunner bug.

  [1] https://github.com/jgraham/rust_mozprofile

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1430157 - Move Rust port of mozprofile to central.

This moves the Rust crate mozprofile into central from GitHub.
The old repository will be graveyarded:

	https://github.com/jgraham/mozprofile

The git history is not considered important, hence this does not
overlay that onto central like we did for testing/geckodriver and
testing/webdriver.

Review commit: https://reviewboard.mozilla.org/r/212510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212510/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1430157 - Move geckodriver to use in-tree mozprofile.

The third_party/rust/mozprofile has not been deleted because mozrunner
also depends on it.  We will have to run "./mach vendor rust" again
once both these changes have landed in order to remove the third-party
dependency from crates.io.  This work is tracked in bug 1430158.

Review commit: https://reviewboard.mozilla.org/r/212512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212512/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Actually we need to land mozrunner first because it uses mozprofile
as a development dependency, and cargo is not too happy about having
two different versions of mozprofile in the same program.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andreas Tolfsen ‹:ato› from comment #3)
> Actually we need to land mozrunner first because it uses mozprofile
> as a development dependency, and cargo is not too happy about having
> two different versions of mozprofile in the same program.

This has been done. Andreas, can you update the patch so that we can get this bug fixed?

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942229 [details]
Bug 1430157 - Move Rust port of mozprofile to central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212510/diff/1-2/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942230 [details]
Bug 1430157 - Move geckodriver to use in-tree mozprofile.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212512/diff/1-2/

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8942229 [details]
Bug 1430157 - Move Rust port of mozprofile to central.

https://reviewboard.mozilla.org/r/212510/#review224576

::: testing/mozbase/rust/mozprofile/.hgignore:1
(Diff revision 2)
> +target

Remove these ignore files (you already added rules to the root .hgignore/.gitignore when doing the previous imports).

Comment 8

[James Graham [:jgraham]]

Comment on attachment 8942230 [details]
Bug 1430157 - Move geckodriver to use in-tree mozprofile.

https://reviewboard.mozilla.org/r/212512/#review224596

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942229 [details]
Bug 1430157 - Move Rust port of mozprofile to central.

https://reviewboard.mozilla.org/r/212510/#review224576

> Remove these ignore files (you already added rules to the root .hgignore/.gitignore when doing the previous imports).

Ah, thanks for reminding me!

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942229 [details]
Bug 1430157 - Move Rust port of mozprofile to central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212510/diff/2-3/

Comment 11

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8942230 [details]
Bug 1430157 - Move geckodriver to use in-tree mozprofile.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212512/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6e62f28bb60
Move Rust port of mozprofile to central. r=ahal
https://hg.mozilla.org/integration/autoland/rev/eb0ddcf7bf57
Move geckodriver to use in-tree mozprofile. r=jgraham

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d6e62f28bb60
https://hg.mozilla.org/mozilla-central/rev/eb0ddcf7bf57