1430187 - search only searches visible area of textarea (version 58.0b15 (64-bit))

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[alexander.kern]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180108140638

Steps to reproduce:

Load a page that has a textarea on it with parts of it not visible (you would need to scroll in the textarea to see the nonvisible parts)
Search for text that is in the non visible party of the textarea


Actual results:

Firefox search says "Phrase not found"


Expected results:

Search should have found what I looked for and scrolled the textarea to that part. If I scroll the textarea so the part I searched for is visible, search does find it like expected.

If you need an example/proof/can't reproduce I can upload screenshots.

Regards and thanks for working on Firefox!

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

User Agent:  Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Firefox: 58.0, Build ID: 20180115093319

I have managed to reproduce this issue on latest Beta 58 and latest Nightly (59.0a1) build on Windows, Linux and Mac. I have reproduce this issue following the next steps:
1. Start Nightly browser and navigate to "https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea" page.
2. Paste a large text in the "textarea".
3. Copy a few words from the bottom of the "textarea".
4. Scroll to the top of the "textarea".
5. Press the Ctrl+F/Cmd+F shortcut and paste the copied text in the Find Bar from the bottom of the browser.
6. Observe the behavior.

[Actual results]:
- There is no match found. 

[Notes]:
- Here is a screen recording with the issue: https://goo.gl/iuj7FZ
- In certain cases the issue is not reproducible if the browser is not maximized.

[Regression]:
This issue is not reproducible on Firefox 57.0.4 release. Considering this I have used the mozregression tools in order to find the regression window. Here are the results:
Last good revision: e6510aeb4e94df029cc47d2d00cd2f19ba5cc9d3
First bad revision: 59045a9d7990aaa8262e28a6bccfda2ca82ecd68
Pushlog: https://goo.gl/sph4Dw
I think bug 1302470 introduced this issue.

Brad can you please take a look at this?

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

Review commit: https://reviewboard.mozilla.org/r/214446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214446/

Comment 3

[Brad Werth [:bradwerth]]

I've got a patch that solves this problem, at the expense of allowing find-in-page success in the very unlikely situation of an unrendered bit of text scrolled away in a visible scrollable container. There may be further improvements I can make on this; I'll check after the test run to see what breaks.

Comment 4

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6630868f135041a7c953d8a5b540ceb50a3ea79f

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1430187 Part 2: Add a test of find-in-page with overflowed textareas.

Review commit: https://reviewboard.mozilla.org/r/214708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214708/

Comment 6

[Brad Werth [:bradwerth]]

Comment on attachment 8944118 [details]
Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214446/diff/1-2/

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 8944118 [details]
Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

https://reviewboard.mozilla.org/r/214446/#review220524

LGTM! Thanks!

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8944540 [details]
Bug 1430187 Part 2: Add a test of find-in-page with overflowed textareas.

https://reviewboard.mozilla.org/r/214708/#review220528

Thanks for this test. Let's ship it!

::: toolkit/modules/tests/browser/browser_Finder_overflowed_textarea.js:3
(Diff revision 1)
> +/* Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +

Please add `"use strict";` below the comment.

::: toolkit/modules/tests/browser/browser_Finder_overflowed_textarea.js:10
(Diff revision 1)
> +
> +  // Generate URI of a big DOM that contains the target text at several
> +  // line positions (to force some targets to be offscreen).
> +  const linesToGenerate = 155;
> +  const linesToInsertTargetText = [5, 50, 150];
> +  let targetCount = linesToInsertTargetText.length;

nit: this can be a `const` as well.

Comment 9

[Brad Werth [:bradwerth]]

Comment on attachment 8944118 [details]
Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214446/diff/2-3/

Comment 10

[Brad Werth [:bradwerth]]

Comment on attachment 8944540 [details]
Bug 1430187 Part 2: Add a test of find-in-page with overflowed textareas.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214708/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8a18bd202a6
Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/56b491b533fa
Part 2: Add a test of find-in-page with overflowed textareas. r=mikedeboer

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d8a18bd202a6
https://hg.mozilla.org/mozilla-central/rev/56b491b533fa

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 14

[Brad Werth [:bradwerth]]

Comment on attachment 8944118 [details]
Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1302470 
[User impact if declined]: Find-in-page will not find overflowed text in textareas and other scrollable containers like iframes.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Strictly increases the number of results reachable by find-in-page.
[String changes made/needed]: none

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8944118 [details]
Bug 1430187 Part 1: Allow find-in-page to unilaterally find text that's out of view in a scrollable container.

Regression from 58, let's fix this in 59. This should be in the beta 5 build.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad738f287aa1
https://hg.mozilla.org/releases/mozilla-beta/rev/130679feb369

Comment 17

[jscher2000]

Can this be considered for a 58.0.2?

Recent SuMo thread: https://support.mozilla.org/questions/1202150

Comment 18

[Brad Werth [:bradwerth]]

(In reply to jscher2000 from comment #17)
> Can this be considered for a 58.0.2?
> 
> Recent SuMo thread: https://support.mozilla.org/questions/1202150

I can't reproduce the issue reported in that thread. The testcase page has no textareas or secondary scrollable content frames, so this patch will not address what the reporter is experiencing (judging by the content of the page given as a testcase).

Comment 19

[jscher2000]

Sorry, try the test case later in the thread: https://www.jeffersonscher.com/temp/find-asia.html 

F3 works properly in Nightly, not in stable (skips matches 9 and 10, for example).

Comment 20

[Brad Werth [:bradwerth]]

(In reply to jscher2000 from comment #19)
> Sorry, try the test case later in the thread:
> https://www.jeffersonscher.com/temp/find-asia.html 

Oops, my mistake. Yes, that case is solved by this patch.

Comment 21

[sallen81]

This seems to not be totally fixed yet. See this simple example: https://www.w3schools.com/cssref/playit.asp?filename=playcss_overflow&preval=auto

Press Ctrl+F to find the word "value" on this page. There should be 9 matches total. Now press F3 to cycle through all the matches. Notice it skips #8 since that is the only match not initially visible in the scrollable DIV.

Comment 22

[sallen81]

(In reply to sallen81 from comment #21)
> This seems to not be totally fixed yet. See this simple example:
> https://www.w3schools.com/cssref/playit.
> asp?filename=playcss_overflow&preval=auto
> 
> Press Ctrl+F to find the word "value" on this page. There should be 9
> matches total. Now press F3 to cycle through all the matches. Notice it
> skips #8 since that is the only match not initially visible in the
> scrollable DIV.

Sorry forgot to mention I'm using 64-bit Firefox 60.0 (stable).

Comment 23

[jscher2000]

(In reply to sallen81 from comment #21)
> This seems to not be totally fixed yet. See this simple example:
> https://www.w3schools.com/cssref/playit.
> asp?filename=playcss_overflow&preval=auto
> 
> Press Ctrl+F to find the word "value" on this page. There should be 9
> matches total. Now press F3 to cycle through all the matches. Notice it
> skips #8 since that is the only match not initially visible in the
> scrollable DIV.

I see the same problem in 60. It's working correctly in Nightly. 

That text is in a div{overflow:auto} instead of a textarea, so it could be a different bug.

Comment 24

[Brad Werth [:bradwerth]]

(In reply to jscher2000 from comment #23)
> I see the same problem in 60. It's working correctly in Nightly. 
> 
> That text is in a div{overflow:auto} instead of a textarea, so it could be a
> different bug.

Yes, this issue was resolved in Bug 1436431. That made the cutoff for inclusion in 61 and is in 61 Beta today.

Comment 25

[devzero]

I have this problem on OSX with firefox 63.0.3

Searching through or list of jira tickets permanently fails and when the searched text is in the visible area, it is found - otherwise it is not found. but that isn't reproducible and seems to depend on the text you enter in search....very weird bug...

Comment 26

[jocke]

I have the same problem in Firefox 63.0.3 and FirefoxDeveloperEdition 64.0b14, on MaxOs.
Before I upgraded to Firefox 63.0.3, I used 57-something, and at that version the search-problem didn't exist.

In Firefox Quantum Extended Support Release 60.3.0esr the problem DON'T exist!

Comment 27

[Brad Werth [:bradwerth]]

(In reply to devzero from comment #25)
> I have this problem on OSX with firefox 63.0.3
> 
> Searching through or list of jira tickets permanently fails and when the
> searched text is in the visible area, it is found - otherwise it is not
> found. but that isn't reproducible and seems to depend on the text you enter
> in search....very weird bug...

We are tracking this issue in Bug 1482147, which is derived from a JIRA example.