1430241 - Text input under e10s triggers assertion in PuppetWidget

Status: RESOLVED FIXED

(GeckoView :: IME, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This assertion [1] is triggered when trying to input text in geckoview_example under e10s.

[1] https://searchfox.org/mozilla-central/rev/7fb999d1d39418fd331284fab909df076b967ac6/widget/PuppetWidget.cpp#342

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1430241 - Call PreventNativeKeyBindings for all key events in child;

Call PreventNativeKeyBindings() for all key events to prevent triggering
an assertion in PuppetWidget.

Review commit: https://reviewboard.mozilla.org/r/214424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214424/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8944103 [details]
Bug 1430241 - Call PreventNativeKeyBindings for all key events in child;

https://reviewboard.mozilla.org/r/214424/#review220212

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ad8d2f1649a
Call PreventNativeKeyBindings for all key events in child; r=esawin

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8ad8d2f1649a

Comment 5

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.