1430255 - RTCRtpContributingSource timestamp has new timebase

Status: NEW

(Core :: WebRTC, enhancement, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

See: https://github.com/w3c/webrtc-pc/issues/1690

RTCRtpContributingSource timestamp has new timebase and reference clock, "performance.timeOrigin + performance.now()".

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review commit: https://reviewboard.mozilla.org/r/214548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214548/

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review commit: https://reviewboard.mozilla.org/r/214550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214550/

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review commit: https://reviewboard.mozilla.org/r/214554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214554/

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/1-2/

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/1-2/

Comment 6

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214554/diff/1-2/

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/2-3/

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/2-3/

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214554/diff/2-3/

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/3-4/

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/3-4/

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214554/diff/3-4/

Comment 13

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/4-5/

Comment 14

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/4-5/

Comment 15

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214554/diff/4-5/

Comment 16

[Michael Froman [:mjf]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

https://reviewboard.mozilla.org/r/214548/#review220270

::: media/webrtc/signaling/src/peerconnection/TransceiverImpl.h:147
(Diff revision 5)
>    const std::string mPCHandle;
>    RefPtr<JsepTransceiver> mJsepTransceiver;
>    std::string mMid;
>    bool mHaveStartedReceiving;
>    bool mHaveSetupTransport;
> +  const TimeStamp& mTimeBase;

Is this really supposed to be a reference?  For example, mPCHandle is copied.

Comment 17

[Michael Froman [:mjf]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

https://reviewboard.mozilla.org/r/214550/#review220272

Looks good to me.

Comment 18

[Michael Froman [:mjf]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

https://reviewboard.mozilla.org/r/214554/#review220274

Looks good to me.

Comment 19

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/5-6/

Comment 20

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/5-6/

Comment 21

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214554/diff/5-6/

Comment 22

[Code Review Bot [:reviewbot]]

Comment on attachment 8944325 [details]
Bug 1430255 - P3 - update RTPSources timebase, js PeerConnection, mochitests

https://reviewboard.mozilla.org/r/214554/#review220336


Static analysis found 1 defect in this patch.
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint check path/to/file` (Python/Javascript/wpt)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: dom/media/tests/mochitest/test_peerConnection_audioSynchronizationSources.html:44
(Diff revision 6)
>           `Synchronization source has audio level. (${source.audioLevel})`);
>        ok(source.audioLevel < 128,
>           `Synchronization source audio level < 128. (${source.audioLevel})`);
>        ok(source.timestamp,
>           `Synchronization source has timestamp (${source.timestamp})`);
> -      ok(Number.isInteger(source.timestamp),
> +      ok(window.performance.now() + window.performance.timeOrigin -

Error: 'ok' is not defined. [eslint: no-undef]

Comment 23

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I see you already have r+, so I don't think you need review from me. Lgtm from a brief glance.

Comment 24

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944317 [details]
Bug 1430255 - P1 - update RTPSources timebase RtpSourceObserver and PeerConnectionImpl;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214548/diff/6-7/

Comment 25

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8944323 [details]
Bug 1430255 - P2 - update RTPSources timebase, gtests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214550/diff/6-7/

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 28

[Intermittent Failures Robot]

2 failures in 3964 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 1

Platform breakdown:

• macosx1014-64: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-10-14&endday=2019-10-20&tree=all

Comment 29

[Intermittent Failures Robot]

1 failures in 4182 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-10-21&endday=2019-10-27&tree=all

Comment 30

[Intermittent Failures Robot]

1 failures in 4314 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-10-28&endday=2019-11-03&tree=all

Comment 31

[Intermittent Failures Robot]

1 failures in 4850 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-11-04&endday=2019-11-10&tree=all

Comment 32

[Intermittent Failures Robot]

6 failures in 4207 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 1

Platform breakdown:

• macosx1014-64: 4
• macosx1014-64-shippable: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-11-11&endday=2019-11-17&tree=all

Comment 33

[Intermittent Failures Robot]

1 failures in 5444 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-11-18&endday=2019-11-24&tree=all

Comment 34

[Intermittent Failures Robot]

1 failures in 4331 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-11-25&endday=2019-12-01&tree=all

Comment 35

[Intermittent Failures Robot]

1 failures in 5144 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-12-02&endday=2019-12-08&tree=all

Comment 36

[Intermittent Failures Robot]

1 failures in 4867 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• windows7-32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-12-09&endday=2019-12-15&tree=all

Comment 37

[Intermittent Failures Robot]

3 failures in 4582 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-central: 2

Platform breakdown:

• macosx1014-64: 2
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 38

[Intermittent Failures Robot]

1 failures in 1365 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-12-23&endday=2019-12-29&tree=all

Comment 39

[Intermittent Failures Robot]

1 failures in 1862 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2019-12-30&endday=2020-01-05&tree=all

Comment 40

[Intermittent Failures Robot]

7 failures in 4472 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7

Platform breakdown:

• macosx1014-64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 41

[Intermittent Failures Robot]

1 failures in 3773 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1430255&startday=2020-01-13&endday=2020-01-19&tree=all

Comment 42

[Intermittent Failures Robot]

3 failures in 4009 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr115: 3

Platform and build breakdown:

• windows7-32-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1430255&startday=2024-02-05&endday=2024-02-11&tree=all