1430303 - Implement ShadowRoot.pointerLockElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

My understanding is that we could leave it after our 1st ship, mark P3 for now. Feel free to correct me if I'm wrong.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

http://w3c-test.org/pointerlock/pointerlock_shadow-manual.html is a manual test for this

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: shadow_dom_pointerlock.diff

This needs automated test too. Passes the manual wpt test

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: shadow_dom_pointerlock_with_test.diff

Just copied existing test and made it use shadow dom.
Passes at least locally.

remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/3e55c5057ed93dcc08079f23c6468b292f1d627f
remote:   https://hg.mozilla.org/try/rev/690c9bac472137acb623e14d6942f0fe8f6b539e
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=690c9bac472137acb623e14d6942f0fe8f6b539e

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: shadow_dom_pointerlock_with_test_2.diff

Still two MOZ_ASSERT's uncomposedDoc->composedDoc changes.

remote: View the pushlog for these changes here:
remote:   https://hg.mozilla.org/try/pushloghtml?changeset=265490b208b36bc33d5dac1fd17dab83ce5f2d5f
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=265490b208b36bc33d5dac1fd17dab83ce5f2d5f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6899f62dea6a
Implement ShadowRoot.pointerLockElement, r=mrbkap

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6899f62dea6a

Comment 8

[Chris Mills [:cmills]]

I've updated this to show it being implemented on the DocumentOrShadowRoot interface, but then marked it as still be implemented on document, in most browser including Firefox (since we don't enable Shadow DOM by default yet):

https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/pointerLockElement

I think this covers it for now.