Implement ShadowRoot.pointerLockElement

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

({dev-doc-complete})

unspecified
mozilla60
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(3 attachments)

My understanding is that we could leave it after our 1st ship, mark P3 for now. Feel free to correct me if I'm wrong.
Priority: -- → P3
(Assignee)

Updated

a year ago
Assignee: nobody → bugs
(Assignee)

Comment 3

a year ago
This needs automated test too. Passes the manual wpt test
(Assignee)

Comment 4

a year ago
Just copied existing test and made it use shadow dom.
Passes at least locally.

remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/3e55c5057ed93dcc08079f23c6468b292f1d627f
remote:   https://hg.mozilla.org/try/rev/690c9bac472137acb623e14d6942f0fe8f6b539e
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=690c9bac472137acb623e14d6942f0fe8f6b539e
Attachment #8944925 - Flags: review?(mrbkap)
Attachment #8944925 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 5

a year ago
Still two MOZ_ASSERT's uncomposedDoc->composedDoc changes.

remote: View the pushlog for these changes here:
remote:   https://hg.mozilla.org/try/pushloghtml?changeset=265490b208b36bc33d5dac1fd17dab83ce5f2d5f
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=265490b208b36bc33d5dac1fd17dab83ce5f2d5f

Comment 6

a year ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6899f62dea6a
Implement ShadowRoot.pointerLockElement, r=mrbkap

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6899f62dea6a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Keywords: dev-doc-needed
I've updated this to show it being implemented on the DocumentOrShadowRoot interface, but then marked it as still be implemented on document, in most browser including Firefox (since we don't enable Shadow DOM by default yet):

https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/pointerLockElement

I think this covers it for now.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.