Implement ShadowRoot.fullscreenElement

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

My understanding is that we could leave it after our 1st ship, mark P3 for now. Feel free to correct me if I'm wrong.
Priority: -- → P3
Assignee: nobody → bugs
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/172323f20ac940de4455b6b89d9eb6c547fea41a
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=172323f20ac940de4455b6b89d9eb6c547fea41a
remote: recorded changegroup in replication log in 0.045s
Attachment #8947933 - Flags: review?(mrbkap)
Comment on attachment 8947933 [details] [diff] [review]
shadowdom_fullscreen.diff

Review of attachment 8947933 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDocument.cpp
@@ +11174,5 @@
>      DispatchFullscreenError("FullscreenDeniedSubDocFullScreen");
>      return false;
>    }
> +  //XXXsmaug Note, we don't follow the latest fullscreen spec here.
> +  //         This whole check could be probably removed.

Is there a bug filed for this? Looking at the spec, this should basically just become an IsInComposedDoc?
Attachment #8947933 - Flags: review?(mrbkap) → review+
There isn't, since after discussing with xidorn, it isn't even clear whether the spec will stay the way it is now, or whether it should be reverted to follow what implementations actually do.
In other words, the spec situation is messy.
Hmm, looks like there is still some assertion to fix.
(In reply to Olli Pettay [:smaug] from comment #4)
> There isn't, since after discussing with xidorn, it isn't even clear whether
> the spec will stay the way it is now, or whether it should be reverted to
> follow what implementations actually do.

I think the editor and I have consensus that we would revert the spec back to match impls on having hierarchy restriction. It is just that he doesn't have time to do the actual edit and work on related tests lately...
Just fixing IsInUncomposedDoc -> IsInComposedDoc in an NS_ASSERTION and rebasing
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0babcbf5ff1e
Implement ShadowRoot.fullscreenElement , r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/0babcbf5ff1e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
As before, I've updated the docs to show this property as implemented on DocumentOrShadowRoot (but with the browser compat data saying it is still implemented on Document in most places):

https://developer.mozilla.org/en-US/docs/Web/API/Document
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot
https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/fullscreenElement
You need to log in before you can comment on or make changes to this bug.