Closed
Bug 1430517
Opened 8 years ago
Closed 8 years ago
Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry
Categories
(Core :: Audio/Video: GMP, enhancement)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
References
Details
Attachments
(1 file)
we no longer needed this telemetry.
So I will remove it.
I'm not sure if ``mMaxVideoShmemsActive``
https://searchfox.org/mozilla-central/rev/137f1b2f434346a0c3756ebfcbdbee4069e15dc8/dom/media/gmp/ChromiumCDMParent.cpp#1083
is a useful information now, so I don't remove this variable in my first patch.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942557 [details]
Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.
https://reviewboard.mozilla.org/r/212808/#review218648
::: dom/media/gmp/ChromiumCDMParent.cpp
(Diff revision 1)
>
> GMP_LOG("ChromiumCDMParent::~ShutdownVideoDecoder(this=%p) "
> "VIDEO_CHROMIUM_CDM_MAX_SHMEMS=%u",
> this,
> mMaxVideoShmemsActive);
> - Telemetry::Accumulate(Telemetry::HistogramID::VIDEO_CHROMIUM_CDM_MAX_SHMEMS,
Please also remove mMaxVideoShmemsActive, it's only used by logging and the telemetry you're removing.
Attachment #8942557 -
Flags: review?(cpearce) → review-
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942557 [details]
Bug 1430517 - Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry.
https://reviewboard.mozilla.org/r/212808/#review218704
Attachment #8942557 -
Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a743132915d
Remove VIDEO_CHROMIUM_CDM_MAX_SHMEMS telemetry. r=cpearce
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•