1430522 - [Form Autofill] Enable address autofill by default on release build

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P3)

Description

[Luke Chang [:lchang] (inactive)]

We are going to ship Address Autofill on Fx58 release build. Let's enable it by default.

Note that the feature is still restricted to the users who use en-US build and are located in the US.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1430522 - [Form Autofill] Enable address autofill by default on release build.

Review commit: https://reviewboard.mozilla.org/r/212866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212866/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8942595 [details]
Bug 1430522 - [Form Autofill] Enable address autofill by default on release build.

https://reviewboard.mozilla.org/r/212866/#review218480

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Luke, could you please nominate this patch for uplift to moz-release. Vance asked whether we can include this in the next RC build.

Gerry, Julien, FYI.

Comment 4

[Luke Chang [:lchang] (inactive)]

No problem. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/947d9e8d3265
[Form Autofill] Enable address autofill by default on release build. r=seanlee

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8942595 [details]
Bug 1430522 - [Form Autofill] Enable address autofill by default on release build.

Approval Request Comment
[Feature/Bug causing the regression]: Form Autofill feature.
[User impact if declined]: Form Autofill won't be available in the release build.
[Is this code covered by automated tests?]: Unnecessary. It flips a pref only. BTW, Form Autofill feature is covered by automated tests entirely.
[Has the fix been verified in Nightly?]: Unnecessary as Form Autofill has been available by default in Nightly and Beta for a long while. Nothing will change after this patch lands Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No.
[Why is the change risky/not risky?]: As Form Autofill is actually available by default in Beta and has passed the QA tests during the beta cycle, it doesn't really change anything from what it is in Fx58 beta.
[String changes made/needed]: N/A

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8942595 [details]
Bug 1430522 - [Form Autofill] Enable address autofill by default on release build.

Enable address autofill in 58. Beta58+.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/947d9e8d3265

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f2fa08b4da33d1e44babe1de999ee078d7ac85cf (FIREFOX_58b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/5096a6c3aefd

Comment 10

[Boaz Dodin]

(In reply to Luke Chang [:lchang] from comment #0)
> Note that the feature is still restricted to the users who use en-US build
> and are located in the US.

May I ask how user's location relevant to autofill feature?..

Comment 11

[Luke Chang [:lchang] (inactive)]

It's based on the pref, "browser.search.region", which can be checked in "about:config" page.

Comment 12

[Matthew N. [:MattN]]

(In reply to Boaz Dodin from comment #10)
> (In reply to Luke Chang [:lchang] from comment #0)
> > Note that the feature is still restricted to the users who use en-US build
> > and are located in the US.
> 
> May I ask how user's location relevant to autofill feature?..

Because the address formats of countries differ. e.g. Province vs. State vs. Region; Postal Code vs. Z.I.P Code; etc. and we are also testing against the top languages of each country since our heuristics to determine the data type which goes in each field involve understanding the label on the field some times.