Closed Bug 1430573 Opened 2 years ago Closed 2 years ago

PlacesDBUtils may change a tag's name without properly signaling the change for Sync

Categories

(Toolkit :: Places, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mak, Assigned: lina)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

If a tag is empty named, PlacesDBUtils renames it to "(no title)" but it doesn't bump any counter.
We could evaluate what to do in the current shape, or just wait for tags to change store and then re-evaluate.
Flags: needinfo?(kit)
Note, this was discovered while looking into bug 1420811, the maintenance task is there from quite some time.
Priority: -- → P3
Bumping the change counter for the tagged bookmarks seems sensible. I wrote a quick patch on the train; I'll leave it to you to decide whether to land it now, and remove when we change tag storage, or just WONTFIX this in favor of migrating tags. Either is OK with me.
Flags: needinfo?(kit)
Comment on attachment 8943068 [details]
Bug 1430573 - Bump the Sync change counter for items with renamed untitled tags.

https://reviewboard.mozilla.org/r/213348/#review219286

it's well contained and taking it shouldn't be a problem. Thanks.
Attachment #8943068 - Flags: review?(mak77) → review+
Assignee: nobody → kit
Status: NEW → ASSIGNED
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eac8b4f5f6b6
Bump the Sync change counter for items with renamed untitled tags. r=mak
https://hg.mozilla.org/mozilla-central/rev/eac8b4f5f6b6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.