1430573 - PlacesDBUtils may change a tag's name without properly signaling the change for Sync

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak]]

If a tag is empty named, PlacesDBUtils renames it to "(no title)" but it doesn't bump any counter.
We could evaluate what to do in the current shape, or just wait for tags to change store and then re-evaluate.

Comment 1

[Marco Bonardo [:mak]]

Note, this was discovered while looking into bug 1420811, the maintenance task is there from quite some time.

Comment 2

[Lina Butler (ex-Mozilla)]

Bumping the change counter for the tagged bookmarks seems sensible. I wrote a quick patch on the train; I'll leave it to you to decide whether to land it now, and remove when we change tag storage, or just WONTFIX this in favor of migrating tags. Either is OK with me.

Comment 3

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1430573 - Bump the Sync change counter for items with renamed untitled tags.

Review commit: https://reviewboard.mozilla.org/r/213348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213348/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8943068 [details]
Bug 1430573 - Bump the Sync change counter for items with renamed untitled tags.

https://reviewboard.mozilla.org/r/213348/#review219286

it's well contained and taking it shouldn't be a problem. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eac8b4f5f6b6
Bump the Sync change counter for items with renamed untitled tags. r=mak

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/eac8b4f5f6b6