Restrict BROWSER_*_DEFAULT probes to parent-process only

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: chutten, Assigned: DarthSwap, Mentored)

Tracking

(Blocks: 1 bug)

49 Branch
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [good first bug][lang=json])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Several "browser is default" probes are set to be recorded in both "main" and "content" processes, but are only ever recorded in the "main" process.

Please go through and set the "record_in_processes" field within toolkit/components/telemetry/Histograms.json to be ["main"] for the following probes:

BROWSER_IS_ASSIST_DEFAULT
BROWSER_IS_USER_DEFAULT
BROWSER_IS_USER_DEFAULT_ERROR
BROWSER_SET_DEFAULT_ALWAYS_CHECK
BROWSER_SET_DEFAULT_DIALOG_PROMPT_RAWCOUNT
BROWSER_SET_DEFAULT_ERROR
BROWSER_SET_DEFAULT_RESULT
(Assignee)

Comment 1

a year ago
I'll be working on this.
(Assignee)

Comment 2

a year ago
I have changed all the requested probes to ["main"] only.
Attachment #8942719 - Flags: review?(chutten)
(Reporter)

Updated

a year ago
Assignee: nobody → swapchamps
Status: NEW → ASSIGNED
(Reporter)

Comment 3

a year ago
Comment on attachment 8942719 [details] [diff] [review]
Bug1430603.patch

Review of attachment 8942719 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, this looks good. Does it build properly?
Attachment #8942719 - Flags: review?(chutten) → review+
(Assignee)

Comment 4

a year ago
I ran the automated tests and they were fine, if that's what you were asking?
(Reporter)

Comment 5

a year ago
I wanted to make sure that you ran `./mach build` and it completed successfully. This file doesn't get rebuilt in an artefact build, so I have to ask :)

I have marked this bug for inclusion in Firefox. Thank you for your contribution!

Would you like some help finding something new to work on? If so, please let me know what you'd like to work on and maybe I can help you find something.
Keywords: checkin-needed

Comment 6

a year ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41bb3e170bf6
Set all BROWSER_*_DEFAULT probes just to ["main"]. r=chutten.
Keywords: checkin-needed
(Assignee)

Comment 7

a year ago
(In reply to Chris H-C :chutten from comment #5)
> I wanted to make sure that you ran `./mach build` and it completed
> successfully. This file doesn't get rebuilt in an artefact build, so I have
> to ask :)

Oh, my bad. Yes, I just did run ./mach build and it completed.

> 
> I have marked this bug for inclusion in Firefox. Thank you for your
> contribution!
> 
> Would you like some help finding something new to work on? If so, please let
> me know what you'd like to work on and maybe I can help you find something.

I want to work on bugs that are a little bit more difficult than good first contributions. I want to increase my contributions in any way. Any help is much appreciated. Thanks! :)
(Reporter)

Comment 8

a year ago
I appreciate the enthusiasm! If you'd like to work a little in Python, bug 1426460 is about making it so we fail later with all the parser errors, instead of failing immediately with just the first error. And there's bug 1207948 which involves treating Android a little differently in about:telemetry.

Do either of those seem interesting?
(Assignee)

Comment 9

a year ago
Yes, thank you!

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/41bb3e170bf6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.