1430616 - InspectorUtils.getCSSValuesForProperty gives wrong results for text-align

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tom Tromey :tromey]

Bug 1255391 points out that InspectorUtils.getCSSValuesForProperty does
not give "match-parent" as a possibly value for "text-align".
I'm filing this separately as it has a different underlying problem
from other incorrect properties mentioned there.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1430616 - correctly find end of keyword table in InspectorUtils;

Currently, InspectorUtils::GetCSSValuesForProperty will not return
"match-parent" for "text-align".  The bug is that InspectorUtils uses
an out-of-date approach to finding the end of the keyword table; and
this approach conflicts with the special "unsafe" handling in
TextAlignUnsafeEnabledPrefChangeCallback:

https://dxr.mozilla.org/mozilla-central/rev/21ddfb9e6cc008e47da89db50e22697dc7b38635/layout/base/nsLayoutUtils.cpp#317-321

Review commit: https://reviewboard.mozilla.org/r/212950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212950/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8942689 [details]
Bug 1430616 - correctly find end of keyword table in InspectorUtils;

https://reviewboard.mozilla.org/r/212950/#review218698

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed10162b58b4
correctly find end of keyword table in InspectorUtils; r=heycam

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ed10162b58b4