Closed Bug 1430635 Opened 2 years ago Closed 2 years ago

Add telemetry to tell us how well script preloading is working

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(2 files, 3 obsolete files)

We attempt to preload scripts, by fetching them from the network in advance of use, which should improve page load times.  However preloaded scripts may end up not being used and therefore end up being a waste of network bandwidth.  Currently we don't have any telemetry to show us how well this system is working.
Patch to add DOM_SCRIPT_PRELOAD_RESULT telemetry which tracks what happens to preloaded scripts.
Attachment #8942707 - Flags: review?(amarchesini)
Attached file telemetry-preload.txt (obsolete) —
Request for data collection review form.
Attachment #8942708 - Flags: review?(liuche)
Uploading a version that works this time...
Attachment #8942707 - Attachment is obsolete: true
Attachment #8942707 - Flags: review?(amarchesini)
Attachment #8942716 - Flags: review?(amarchesini)
Priority: -- → P2
Comment on attachment 8942716 [details] [diff] [review]
bug1430635-script-preload-telemetry v2

Review of attachment 8942716 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +12613,5 @@
>    },
> +  "DOM_SCRIPT_PRELOAD_RESULT": {
> +    "record_in_processes": ["main", "content"],
> +    "alert_emails": ["jcoppeard@mozilla.com"],
> +    "expires_in_version": "never",

You must have a review from a telemetry peer. And I don't think they will be happy about this 'never'.
Attachment #8942716 - Flags: review?(amarchesini) → review+
Updated patch with expires_in_version set to 63.
Attachment #8942716 - Attachment is obsolete: true
Attachment #8943196 - Flags: review+
Updated form with 6 month expiry.
Attachment #8942708 - Attachment is obsolete: true
Attachment #8942708 - Flags: review?(liuche)
Attachment #8943197 - Flags: review?(liuche)
Comment on attachment 8943197 [details]
telemetry-preload.txt v2

Data-review only

> Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, Histograms

> Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
Yes, Firefox data controls

> If the request is for permanent data collection, is there someone who will monitor the data over time?**
No, expires in 63, jonco will monitor

> Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 1

> Is the data collection request for default-on or default-off?
default on

> Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No

> Is the data collection covered by the existing Firefox privacy notice?
Yes

> Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Expires in 63
Attachment #8943197 - Flags: review?(liuche) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3dd2335e142
Add telemetry to track how often preloaded scripts are used. r=baku, data-review=liuche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f3dd2335e142
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.