1430658 - Saving of print settings inconsistently handles prefs

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

We have the following two bool prefs that default to true in all.js:

  - print.use_global_printsettings

  - print.save_print_settings

In two places we ignore the value of print.save_print_settings if print.use_global_printsettings is set to false:

  - nsGlobalWindowOuter::PrintOuter

  - Printing.shouldSavePrintSettings in
    toolkit/content/browser-content.js

but then in two other places we fail to check print.use_global_printsettings:

  - PrintUtils.showPageSetup in
    toolkit/components/printing/content/printUtils.js

  - nsPrintDialogServiceX::Show in
    widget/cocoa/nsPrintDialogX.mm

This could be responsible for some/all of the bugs about print settings being saved inconsistently that I've seen while triaging the printing bugs.

Comment 1

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 2

[Jonathan Watt [:jwatt]]

This was fixed by bug 855889.