Closed Bug 1430696 Opened 2 years ago Closed 2 years ago
Windows PGO is busted in MSVC 15
It looks like these patches may fix the PGO build? https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cb95c7123ee2c41edd27f97a0c2f2ab519f52d2
:rillian - what are you thoughts on the win32 fix-hack?
I'm fine with it, but this is third_party code which gets updated to upstream's version periodically, so it won't stay fixed. If this is needed for future revisions, best to update the vendor script to apply the patch on import. That's https://hg.mozilla.org/mozilla-central/file/tip/python/mozbuild/mozbuild/vendor_aom.py
2 years ago
It would be good to restrict these to defined(_M_IX86) and defined(_M_AMD64) to limit the damage of the deoptimizations.
These patches landed as part of bug 1424281.
No longer blocks: VS15.6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: VS15.6
You need to log in before you can comment on or make changes to this bug.