1430696 - Windows PGO is busted in MSVC 15.5.3

Status: RESOLVED DUPLICATE of bug 1424281

(Firefox Build System :: General, defect)

Description

[Tom Ritter [:tjr]]

See Bug 1424281 (especially comment 5) for more info and a fix for Windows x64

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1430696 Try de-optimizing a function to make Win64 PGO builds happy.

Review commit: https://reviewboard.mozilla.org/r/213268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213268/

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1430696 Try to fix the win32 PGO

Review commit: https://reviewboard.mozilla.org/r/213270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213270/

Comment 3

[Tom Ritter [:tjr]]

It looks like these patches may fix the PGO build?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cb95c7123ee2c41edd27f97a0c2f2ab519f52d2

Comment 4

[Tom Ritter [:tjr]]

:rillian - what are you thoughts on the win32 fix-hack?

Comment 5

[Ralph Giles (:rillian)]

I'm fine with it, but this is third_party code which gets updated to upstream's version periodically, so it won't stay fixed. If this is needed for future revisions, best to update the vendor script to apply the patch on import. That's https://hg.mozilla.org/mozilla-central/file/tip/python/mozbuild/mozbuild/vendor_aom.py

Comment 6

[(Away)]

It would be good to restrict these to defined(_M_IX86) and defined(_M_AMD64) to limit the damage of the deoptimizations.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

These patches landed as part of bug 1424281.