1430700 - regression: SVGs are invisible on web.whatsapp.com after switching tabs

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Noticed on https://web.whatsapp.com.

https://www.w3schools.com/graphics/tryit.asp?filename=trysvg_circle
Open another tab, switch back. The red circle went away (bug). Click into the right half of the website to show it.

mozregression --good 2018-01-14 --bad 2018-01-16 --pref gfx.webrender.all:true layout.display-list.retain:false startup.homepage_welcome_url:"https://www.w3schools.com/graphics/tryit.asp?filename=trysvg_circle"
> 4:09.76 INFO: Last good revision: 52397f10a40b2dc2c2e07440e1b9c986eec112fa
> 4:09.76 INFO: First bad revision: 3ae6cbde5225f24eb512aff7acba6be65efd29ec
> 4:09.76 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=52397f10a40b2dc2c2e07440e1b9c986eec112fa&tochange=3ae6cbde5225f24eb512aff7acba6be65efd29ec

> 3ae6cbde5225	sotaro — Bug 1429694 - Fix WebRenderLayerManager::ClearCachedResources r=nical

Comment 1

[Sotaro Ikeda [:sotaro]]

It seems that we need to add ClearCachedResources() to WebRenderFallbackData.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Implement WebRenderFallbackData::ClearCachedResources()

Implement WebRenderFallbackData::ClearCachedResources() to handle ClearCachedResources() correctly.

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f590e43cd727fb034cf6b98b29746f9ff58de98

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8942825 [details] [diff] [review]
patch - Implement WebRenderFallbackData::ClearCachedResources()

Review of attachment 8942825 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't realize we were calling a virtual function in a destructor. It's one of the most error prone things in C++ and a very common source of bugs. Please move the implementations of ClearCachedResources in non-virtual methods (that ClearCachedResource can call) and make sure to call the non-virtual methods in the destructors instead of the virtual ones. That will probably save us a weird bug in a year or so by the time we forget about this.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Implement WebRenderFallbackData::ClearCachedResources()

Apply the comment.

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=deb4328d53263de8aa4deb504f0910afc1871fc9

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8943082 [details] [diff] [review]
patch - Implement WebRenderFallbackData::ClearCachedResources()

Review of attachment 8943082 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/524088f8b35c
Implement WebRenderFallbackData::ClearCachedResources() r=nical

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/524088f8b35c

Comment 11

[Darkspirit]

Verified fixed in Nightly 59 x64 20180118220148 de_DE @ Debian Testing (KDE, Radeon RX480). Thank you! :)