1430723 - Using fixed width of waterfall column

Status: RESOLVED WONTFIX

(DevTools :: Netmonitor, enhancement, P3)

Description

[Ricky Chien [:rickychien] (inactive)]

The current width of waterfall column relies on an additional props `waterfallWidth` [1] and get updated at [2] when component mounted. This step can be removed once we use fixed width of waterfall column, so that some unnecessary code can be removed as well.


[1] https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/RequestListHeader.js#225

[2]https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/RequestListHeader.js#90-99

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Note that the current waterfall column will be disabled when screen width < 700px, so I think using fixed width of waterfall in normal screen size > 700px would be fine for usability.

https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/assets/styles/RequestList.css#642

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1430723 - Using fixed width of waterfall column

Review commit: https://reviewboard.mozilla.org/r/213086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213086/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8942840 [details]
Bug 1430723 - Using fixed width of waterfall column

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213086/diff/1-2/

Comment 4

[Alexandre Poirot [:ochameau]]

Ricky, Do you mind if I take over this bug?

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Sure, here you go!

Comment 6

[Alexandre Poirot [:ochameau]]

After some more investigation, it wasn't mandatory to prevent reflows from bug 1431132.
I think at this point it is better to directly focus on bug 1358414.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The bug is inactive, moving to the backlog (P3)
Honza

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Closing, according to comment #6

Alex, feel free to reopen if there is something we can do here to improve the performance.

Honza