1430725 - [Wayland] - minor build fixes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

We're missing some minor build fixes to wayland target.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1430725 - Use mozilla::widget namespace explicitly for ScreenHelperGTK::GetGTKMonitorScaleFactor() call,

Review commit: https://reviewboard.mozilla.org/r/213104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213104/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1430725 - dlsym gdk_wayland_display_get_wl_display() function,

Review commit: https://reviewboard.mozilla.org/r/213106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213106/

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1430725 - Include nsClipboardWayland.cpp to wayland build,

Review commit: https://reviewboard.mozilla.org/r/213108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213108/

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1430725 - Undefine X11 None at ScreenHelperGTK.h as it conflicts our JS code,

Review commit: https://reviewboard.mozilla.org/r/213110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213110/

Comment 5

[Jan Horak [:jhorak]]

Comment on attachment 8942850 [details]
Bug 1430725 - dlsym gdk_wayland_display_get_wl_display() function,

https://reviewboard.mozilla.org/r/213106/#review218790

Comment 6

[Jan Horak [:jhorak]]

Comment on attachment 8942851 [details]
Bug 1430725 - Include nsClipboardWayland.cpp to wayland build,

https://reviewboard.mozilla.org/r/213108/#review218792

Comment 7

[Jan Horak [:jhorak]]

Comment on attachment 8942852 [details]
Bug 1430725 - Undefine X11 None at ScreenHelperGTK.h as it conflicts our JS code,

https://reviewboard.mozilla.org/r/213110/#review218796

::: commit-message-ec60e:1
(Diff revision 1)
> +Bug 1430725 - Udefine X11 None at ScreenHelperGTK.h as it conflicts our JS code, r?jhorak

typo: Undefine

Comment 8

[Jan Horak [:jhorak]]

Comment on attachment 8942849 [details]
Bug 1430725 - Use mozilla::widget namespace explicitly for ScreenHelperGTK::GetGTKMonitorScaleFactor() call,

https://reviewboard.mozilla.org/r/213104/#review218800

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8942852 [details]
Bug 1430725 - Undefine X11 None at ScreenHelperGTK.h as it conflicts our JS code,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213110/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301e2e924d21
Use mozilla::widget namespace explicitly for ScreenHelperGTK::GetGTKMonitorScaleFactor() call, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/257ed4705a15
dlsym gdk_wayland_display_get_wl_display() function, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/44830cef5749
Include nsClipboardWayland.cpp to wayland build, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/3fa7cfb635b7
Undefine X11 None at ScreenHelperGTK.h as it conflicts our JS code, r=jhorak

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/301e2e924d21
https://hg.mozilla.org/mozilla-central/rev/257ed4705a15
https://hg.mozilla.org/mozilla-central/rev/44830cef5749
https://hg.mozilla.org/mozilla-central/rev/3fa7cfb635b7