Closed
Bug 1430758
Opened 8 years ago
Closed 8 years ago
'Save link as' does not work in non-e10s
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | unaffected |
| firefox59 | --- | fixed |
People
(Reporter: Oriol, Assigned: baku)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1013 bytes,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
Regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=96fdf13f21180ba7e77b2ed95cc93b9e22cc721b&tochange=6b4cebf12e3fd1d1603f03b84a6cfdeb200204fc
Steps:
1. Disable e10s
2. Navigate to the link above
2. Right-click some link in that page
3. Choose 'Save link as' in the context menu
Expected: a save dialog appears
Result: no dialog, the browser console shows
: Component returned failure code: 0x805e0006 [nsIChannel.asyncOpen2]
saveHelper chrome://browser/content/nsContextMenu.js:1193:5
saveLink chrome://browser/content/nsContextMenu.js:1201:5
oncommand chrome://browser/content/browser.xul:1:1
Flags: needinfo?(amarchesini)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8942894 -
Flags: review?(ckerschb)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8942894 [details] [diff] [review]
csp.patch
Review of attachment 8942894 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for fixing Baku. r=me
Attachment #8942894 -
Flags: review?(ckerschb) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2951624227cc
No CSP directive for nsIContentPolicy::TYPE_SAVEAS_DOWNLOAD, r=ckerschb
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•8 years ago
|
Blocks: 1398229
status-firefox57:
--- → unaffected
status-firefox58:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Version: unspecified → Trunk
|
||
Comment 5•8 years ago
|
||
I have reproduced this bug with Nightly 59.0a1 (2018-01-16) on ubuntu 16.04
The bug's fix is now verified with Latest Beta 59.0b10
Build ID 20180215111455
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
You need to log in
before you can comment on or make changes to this bug.
Description
•