1430773 - The eyedropper should not copy colors as uppercase to the clipboard

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Pascal Chevrel:pascalc]

Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20180115220459

When you use the eyedropper, the value copied to the clipboard is in uppercase. The inspector displays hexadecimal values in lowercase by default and it seems most project these days use lowercase for CSS color code.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

There may be good reason behind this change, Patrick, does this ring a bell ?

Anyway, if someone is willing to work on this, this is the place where the color is turned uppercase: https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/devtools/server/actors/highlighters/eye-dropper.js#525-528

The fix should be about removing the `.toUppercase()` call, and then probably fix all the test that were asserting uppercased hex colors.

Comment 2

[Patrick Brosset <:pbro>]

Some work around this was done in bug 1124210. But it looks like, although the bug was about the eyedropper initially, the eyedropper wasn't changed as part of this bug.
So, it looks fine to me to change the eyedropper to display lower case here in this bug.

Comment 3

[Abhinav Koppula]

Attachment: Bug 1430773 - The eyedropper should not copy colors as uppercase to the clipboard;

Review commit: https://reviewboard.mozilla.org/r/213800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213800/

Comment 4

[Abhinav Koppula]

Hi Nicolas,
I've created a review request for this issue. Can you review this?

TRY link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=726b7e8b47ac47c16ffef1a6bdc8f69c2bb50404

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8943461 [details]
Bug 1430773 - The eyedropper should not copy colors as uppercase to the clipboard;

It looks good to me, but I may be missing something.
Let's see what Patrick thinks :)

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8943461 [details]
Bug 1430773 - The eyedropper should not copy colors as uppercase to the clipboard;

https://reviewboard.mozilla.org/r/213800/#review219616

Looks good. Thank you!
I'll push this to TRY too.

Comment 7

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ccf9b010a04faca325c73f23d14d9b0052210b0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/822f8d3aff90
The eyedropper should not copy colors as uppercase to the clipboard; r=pbro

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/822f8d3aff90

Comment 10

[Md Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2018-01-16) on Windows 10, 64 Bit!

The bug's fix is now verified with Latest Beta!

Build ID   20180215111455
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 11

[Oana Botisan, Desktop QA]

I verified the fix on Ubuntu 16.04 x64 and macOS 10.13 using latest Nightly 60.0a1 and beta 59.0b10, too. According to this result and the one from comment 10, I will mark the bug verified fixed.