Closed Bug 1430773 Opened 3 years ago Closed 3 years ago

The eyedropper should not copy colors as uppercase to the clipboard

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox59 verified, firefox60 verified)

VERIFIED FIXED
Firefox 59
Tracking Status
firefox59 --- verified
firefox60 --- verified

People

(Reporter: pascalc, Assigned: abhinav.koppula)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20180115220459

When you use the eyedropper, the value copied to the clipboard is in uppercase. The inspector displays hexadecimal values in lowercase by default and it seems most project these days use lowercase for CSS color code.
There may be good reason behind this change, Patrick, does this ring a bell ?

Anyway, if someone is willing to work on this, this is the place where the color is turned uppercase: https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/devtools/server/actors/highlighters/eye-dropper.js#525-528

The fix should be about removing the `.toUppercase()` call, and then probably fix all the test that were asserting uppercased hex colors.
Component: Developer Tools → Developer Tools: Inspector
Flags: needinfo?(pbrosset)
Keywords: good-first-bug
Some work around this was done in bug 1124210. But it looks like, although the bug was about the eyedropper initially, the eyedropper wasn't changed as part of this bug.
So, it looks fine to me to change the eyedropper to display lower case here in this bug.
Flags: needinfo?(pbrosset)
See Also: → 1124210
Hi Nicolas,
I've created a review request for this issue. Can you review this?

TRY link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=726b7e8b47ac47c16ffef1a6bdc8f69c2bb50404
Comment on attachment 8943461 [details]
Bug 1430773 - The eyedropper should not copy colors as uppercase to the clipboard;

It looks good to me, but I may be missing something.
Let's see what Patrick thinks :)
Attachment #8943461 - Flags: review?(nchevobbe) → review?(pbrosset)
Comment on attachment 8943461 [details]
Bug 1430773 - The eyedropper should not copy colors as uppercase to the clipboard;

https://reviewboard.mozilla.org/r/213800/#review219616

Looks good. Thank you!
I'll push this to TRY too.
Attachment #8943461 - Flags: review?(pbrosset) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ccf9b010a04faca325c73f23d14d9b0052210b0
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/822f8d3aff90
The eyedropper should not copy colors as uppercase to the clipboard; r=pbro
https://hg.mozilla.org/mozilla-central/rev/822f8d3aff90
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I have reproduced this bug with Nightly 59.0a1 (2018-01-16) on Windows 10, 64 Bit!

The bug's fix is now verified with Latest Beta!

Build ID   20180215111455
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [testday-20180216]
I verified the fix on Ubuntu 16.04 x64 and macOS 10.13 using latest Nightly 60.0a1 and beta 59.0b10, too. According to this result and the one from comment 10, I will mark the bug verified fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.