Closed Bug 1430792 Opened 2 years ago Closed 2 years ago

ExampleStylesheet.h should not be formatted

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

when doing ./mach clang-format -p ., it is going to reformat all including obj-* files.
It isn't a big deal but for ExampleStylesheet.h, it is causing some issues:
 In file included from /home/sylvestre/dev/mozilla/mozilla-central.hg/layout/style/test/gtest/StyloParsingBench.cpp:10:0,
                  from /home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/layout/style/test/gtest/Unified_cpp_style_test_gtest0.cpp:2:
 /home/sylvestre/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/layout/style/test/gtest/ExampleStylesheet.h:1:80: error: backslash-newline at end of file [-Werror]
  #define EXAMPLE_STYLESHEET                                                     \

We should probably ignore this file.
Comment on attachment 8942918 [details]
Bug 1430792 - ExampleStylesheet.h should not be formatted

https://reviewboard.mozilla.org/r/213186/#review218870
Attachment #8942918 - Flags: review?(bpostelnicu) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a2a6750304e
ExampleStylesheet.h should not be formatted r=andi
https://hg.mozilla.org/mozilla-central/rev/3a2a6750304e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.