1430797 - Sometimes APZ stops working

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

20180115220459

I don't know how to reproduce this.

When I woke my Mac up this morning, my Firefox Nightly build was no longer able to scroll using the touchpad or by dragging the scrollbar thumb. Scrolling with the arrow keys and the space bar is still working.
This affects all tabs in all windows.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This appears to be because we're falling back to Basic Compositor on the main window on OS X, and the WR hit-test doesn't work in that case. The falling back is because of bug 1377321, however when I back that patch out locally I just get a blank white window instead. I verified that the regression is from that by running inbound builds before and after that landed, though. So either my local set up is hosed (in terms of testing the backout) or something else landed since that patch to break WR-enabled OS X.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Oh, it was my local setup that was hosed.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1430797 - Allow webrender on eWindowType_child, so that it is used on OS X.

Review commit: https://reviewboard.mozilla.org/r/213260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213260/

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8942996 [details]
Bug 1430797 - Allow webrender on eWindowType_child, so that it is used on OS X.

https://reviewboard.mozilla.org/r/213260/#review219000

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8942996 [details]
Bug 1430797 - Allow webrender on eWindowType_child, so that it is used on OS X.

https://reviewboard.mozilla.org/r/213260/#review219002

Let's add eWindowType_dialog as well.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8942996 [details]
Bug 1430797 - Allow webrender on eWindowType_child, so that it is used on OS X.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213260/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe6f236e1fb5
Allow webrender on eWindowType_child, so that it is used on OS X. r=nical

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 84dc1a6d0ede40081791534b28b9973a640067d1 -d d88cb52f392d: rebasing 442751:84dc1a6d0ede "Bug 1430797 - Allow webrender on eWindowType_child, so that it is used on OS X. r=mstange,nical" (tip)
merging widget/nsBaseWidget.cpp
warning: conflicts while merging widget/nsBaseWidget.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Hmm it autolanded the old version (which I triggered before Markus' comment). I'll land a follow-up with the eWindowType_dialog change.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fe6f236e1fb5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f05239cea76c
Follow-up to address review comment. r=mstange

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f05239cea76c