1431009 - Crash in nsDocumentViewer::~nsDocumentViewer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-9a649bf4-4daa-4e9a-9d9f-3f93b0180117.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll nsDocumentViewer::~nsDocumentViewer layout/base/nsDocumentViewer.cpp:557
1 xul.dll nsDocumentViewer::Show layout/base/nsDocumentViewer.cpp:2133
2 xul.dll nsPresContext::EnsureVisible layout/base/nsPresContext.cpp:2246
3 xul.dll mozilla::PresShell::UnsuppressAndInvalidate layout/base/PresShell.cpp:3916
4 xul.dll nsDocumentViewer::LoadComplete layout/base/nsDocumentViewer.cpp:1104
5 xul.dll nsDocShell::EndPageLoad docshell/base/nsDocShell.cpp:7798
6 xul.dll nsDocShell::OnStateChange docshell/base/nsDocShell.cpp:7596
7 xul.dll nsDocLoader::DoFireOnStateChange uriloader/base/nsDocLoader.cpp:1321
8 xul.dll nsDocLoader::doStopDocumentLoad uriloader/base/nsDocLoader.cpp:862
9 xul.dll nsTArray_base<nsTArrayInfallibleAllocator, nsTArray_CopyWithMemutils>::EnsureCapacity<nsTArrayInfallibleAllocator> xpcom/ds/nsTArray-inl.h:136

=============================================================

these content crashes with MOZ_RELEASE_ASSERT(mDestroyRefCount == 0) started appearing on 59.0a1 and now 58.0rc1.

Comment 1

[Bob Owen (:bobowen)]

I'll duplicate over when appropriate.

Comment 2

[Jim Mathies [:jimm]]

New sig tied to a release assert that was uplifted to 58 recently.

Comment 3

[Bob Owen (:bobowen)]

This is hopefully already fixed in 59.
There are two reports in Beta but 59b0 doesn't include this, so I guess it's built from an earlier branch.

Comment 4

[Mike Taylor [:miketaylr]]

No crashes in 59 in the past 2 weeks, just those 2 59b0 (e1028926-b361-4f3d-834d-ef2d60180119, a27905b8-1333-481c-ab98-32efd0180118) on the 18th and 19th.

Comment 5

[Andrew Overholt [:overholt]]

Are we able to fix this in 58? Should we? (Asking for a friend)

Comment 6

[Mike Taylor [:miketaylr]]

Bob, no more 59 reports. Do we close this?

Comment 7

[Bob Owen (:bobowen)]

In 58.0.2.