Closed Bug 1431021 Opened 2 years ago Closed 2 years ago

Remove unused isContentFrame from contentAreaUtils.js

Categories

(Toolkit :: General, enhancement)

Product:
Toolkit
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1431021 - Remove unused isContentFrame from contentAreaUtils.js.
59 bytes, text/x-review-board-request
florian
: review+
Details 
As part of cleaning up browser window globals, we should remove isContentFrame from contentAreaUtils.js as it is not used.
Comment on attachment 8943156 [details]
Bug 1431021 - Remove unused isContentFrame from contentAreaUtils.js.

https://reviewboard.mozilla.org/r/213504/#review219262

I agree we should remove this, but it's used in:
editor/ui/composer/content/editorApplicationOverlay.js
suite/browser/navigator.js

maybe needinfo someone from SeaMonkey to take care of copying that function where they want it?
Attachment #8943156 - Flags: review?(florian) → review+
fgr: fyi, this will be landing soon. You may want to move the function to SeaMonkey somewhere.
Flags: needinfo?(frgrahl)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2768c5b6f287
Remove unused isContentFrame from contentAreaUtils.js. r=florian
ok
Flags: needinfo?(frgrahl)
https://hg.mozilla.org/mozilla-central/rev/2768c5b6f287
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.