Closed
Bug 143103
Opened 23 years ago
Closed 21 years ago
spacetrace should show progress
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alecf, Assigned: alecf)
Details
Attachments
(1 file)
2.62 KB,
patch
|
Details | Diff | Splinter Review |
I've got a little patch for spacetrace to show progress as it reads in data from
the trace-malloc file...
Assignee | ||
Comment 1•23 years ago
|
||
reviews?
Comment 2•23 years ago
|
||
Comment on attachment 82845 [details] [diff] [review]
add progress meter
Wondering if "printf("%c\r", event_progress_chars[events %
EVENT_HANDLER_NUM_CHARS]); would do the nearly the same thing.
Maybe you had initially wanted to gate entry into the "if" on some period
(every 1<<12 events show progress), but I only see the if getting skipped once
in 1<<12 times.
Enough of me guessing :) maybe I'm missing something?
Assignee | ||
Comment 3•23 years ago
|
||
bwah! you're right. I think I was experimenting with this so much I ended up
with a very convoluted if(), and just pasted the patch in here without reading
it. I'll fix 'er up.
Assignee | ||
Comment 4•21 years ago
|
||
I took garrett's advice, and now I own this tool. The patch was minimal.
Marking fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•