1431030 - Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Playing with different coding styles, the NS_NPAPIPLUGIN_CALLBACK definition can be altered and causing the build to fail on Windows
 #if defined(XP_WIN)
-#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type (__stdcall * _name)
+#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type(__stdcall *_name)
 #else
-#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type (* _name)
+#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type(*_name)
 #endif


     INFO -  z:\build\build\src\dom\plugins\base\nsNPAPIPlugin.h(18): error C2220: warning treated as error - no 'object' file generated
     INFO -  z:\build\build\src\dom\plugins\base\nsNPAPIPlugin.h(18): warning C4005: 'NS_NPAPIPLUGIN_CALLBACK': macro redefinition
     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/plugins/PluginModuleChild.h(38): note: see previous definition of 'NS_NPAPIPLUGIN_CALLBACK'

I propose that we disable the automatic formatting for this.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1431030 - Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

Review commit: https://reviewboard.mozilla.org/r/213512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213512/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8943176 [details]
Bug 1431030 - Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

https://reviewboard.mozilla.org/r/213512/#review219364

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fdccaab2e7c
Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions r=jimm

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 2fdccaab2e7c (bug 1431030) for build bustages on a CLOSED TREE

https://treeherder.mozilla.org/logviewer.html#?job_id=157107322&repo=autoland&lineNumber=17690

https://hg.mozilla.org/integration/autoland/rev/668b67f1c900d6c1a1ca19006fb4cf340b30a436

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2fdccaab2e7c887b55455384c27f8c6344f01e4f&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8943176 [details]
Bug 1431030 - Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213512/diff/1-2/

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Not sure what happened. Fixed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1903f1d75e0
Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions r=jimm

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e1903f1d75e0