Closed Bug 1431030 Opened 2 years ago Closed 2 years ago

Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Playing with different coding styles, the NS_NPAPIPLUGIN_CALLBACK definition can be altered and causing the build to fail on Windows
 #if defined(XP_WIN)
-#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type (__stdcall * _name)
+#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type(__stdcall *_name)
 #else
-#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type (* _name)
+#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type(*_name)
 #endif


     INFO -  z:\build\build\src\dom\plugins\base\nsNPAPIPlugin.h(18): error C2220: warning treated as error - no 'object' file generated
     INFO -  z:\build\build\src\dom\plugins\base\nsNPAPIPlugin.h(18): warning C4005: 'NS_NPAPIPLUGIN_CALLBACK': macro redefinition
     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/plugins/PluginModuleChild.h(38): note: see previous definition of 'NS_NPAPIPLUGIN_CALLBACK'

I propose that we disable the automatic formatting for this.
Comment on attachment 8943176 [details]
Bug 1431030 - Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions

https://reviewboard.mozilla.org/r/213512/#review219364
Attachment #8943176 - Flags: review?(jmathies) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fdccaab2e7c
Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions r=jimm
Not sure what happened. Fixed.
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1903f1d75e0
Ignore the automatic formatting of the NS_NPAPIPLUGIN_CALLBACK definitions r=jimm
https://hg.mozilla.org/mozilla-central/rev/e1903f1d75e0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.