1431041 - :placeholder-shown doesn't work for input type number

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[liseu]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180104112904

Steps to reproduce:

Demo - https://codepen.io/anon/pen/eyPMrZ

1. create input with type number
2. set :placeholder-shown styles on number input


Actual results:

Placeholder is visible, :placeholder-shown styles haven't been applied.


Expected results:

:placeholder-shown styles should be applied.

Comment 1

[Flore Allemandou [:flore]]

Confirmed on latest nightly

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1431041: Make placeholder apply to <input type="number">.

Review commit: https://reviewboard.mozilla.org/r/213572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213572/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is more like a DOM bug, but I'll take it anyway. Thanks for the report, and thanks Flore!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8943245 [details]
Bug 1431041: Make placeholder apply to <input type="number">.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213572/diff/1-2/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8943245 [details]
Bug 1431041: Make placeholder apply to <input type="number">.

https://reviewboard.mozilla.org/r/213572/#review219338

And the placeholder is cleared correctly when some value is set to the input element?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

(In reply to Olli Pettay [:smaug] (please try to find other reviewers for non-web components patches) from comment #5)
> Comment on attachment 8943245 [details]
> Bug 1431041: Make placeholder apply to <input type="number">.
> 
> https://reviewboard.mozilla.org/r/213572/#review219338
> 
> And the placeholder is cleared correctly when some value is set to the input
> element?

Blerg, yeah, though I only tested it with valid values. Patch incoming...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1431041: Fix placeholder-shown when the value of the input is invalid.

Wow, the setup for <input type="number"> is really weird :(.

Looking at the callers, this should be sane.

Review commit: https://reviewboard.mozilla.org/r/213646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213646/

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8943245 [details]
Bug 1431041: Make placeholder apply to <input type="number">.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213572/diff/2-3/

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8943245 [details]
Bug 1431041: Make placeholder apply to <input type="number">.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213572/diff/3-4/

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8943335 [details]
Bug 1431041: Fix placeholder-shown when the value of the input is invalid.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213646/diff/1-2/

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8943335 [details]
Bug 1431041: Fix placeholder-shown when the value of the input is invalid.

https://reviewboard.mozilla.org/r/213646/#review219514

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a4c3ab0ade8
Make placeholder apply to <input type="number">. r=smaug
https://hg.mozilla.org/integration/autoland/rev/57641ee7058f
Fix placeholder-shown when the value of the input is invalid. r=smaug

Comment 13

[Natalia Csoregi [:nataliaCs]]

Backed out for failing dom/html/test/forms/test_input_number_placeholder_shown.html & reftests/css-placeholder/input/placeholdershown.html

Backout: https://hg.mozilla.org/integration/autoland/rev/13c36da892b2dc4b9ba9461d6038f5d78754d58f

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=57641ee7058f016c28bbb67b6a224d45e1b7fb9e&selectedJob=157058538

failure logs:
https://treeherder.mozilla.org/logviewer.html#?job_id=157057598&repo=autoland&lineNumber=6525
https://treeherder.mozilla.org/logviewer.html#?job_id=157058538&repo=autoland&lineNumber=1960

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbf8db3f65eb
Make placeholder apply to <input type="number">. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b06e69e9a326
Fix placeholder-shown when the value of the input is invalid. r=smaug

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Thanks natalia, pushed with a fix and with a reftest splitted for android.

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/fbf8db3f65eb
https://hg.mozilla.org/mozilla-central/rev/b06e69e9a326