Make eslint deal with ChromeUtils-imported globals

RESOLVED FIXED in Firefox 59

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
mozilla59
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

In bug 1425611 and deps we're switching from Cu.import to ChromeUtils.import .

To facilitate this, we need eslint to understand that they're effectively equivalent.
See Also: → 1431104
Comment on attachment 8943240 [details]
Bug 1431069 - allow eslint to deal with ChromeUtils imports,

https://reviewboard.mozilla.org/r/213568/#review219680
Attachment #8943240 - Flags: review?(standard8) → review+
Hmm, so I just realised we should update our other rules as well - no-import-into-var-and-global and no-single-arg-cu-import - otherwise we run the risk of regressing with ChromeUtils. The tests for those should also be updated.

I'd like that to be done before we start migrating everyone across.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Mark Banner (:standard8) from comment #3)
> Hmm, so I just realised we should update our other rules as well -
> no-import-into-var-and-global and no-single-arg-cu-import - otherwise we run
> the risk of regressing with ChromeUtils. The tests for those should also be
> updated.
> 
> I'd like that to be done before we start migrating everyone across.

Ah, good points. Done. :-)
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/046fb034b323
allow eslint to deal with ChromeUtils imports, r=standard8
https://hg.mozilla.org/mozilla-central/rev/046fb034b323
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.