1431069 - Make eslint deal with ChromeUtils-imported globals

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[:Gijs (he/him)]

In bug 1425611 and deps we're switching from Cu.import to ChromeUtils.import .

To facilitate this, we need eslint to understand that they're effectively equivalent.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1431069 - allow eslint to deal with ChromeUtils imports,

Review commit: https://reviewboard.mozilla.org/r/213568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213568/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8943240 [details]
Bug 1431069 - allow eslint to deal with ChromeUtils imports,

https://reviewboard.mozilla.org/r/213568/#review219680

Comment 3

[Mark Banner (:standard8)]

Hmm, so I just realised we should update our other rules as well - no-import-into-var-and-global and no-single-arg-cu-import - otherwise we run the risk of regressing with ChromeUtils. The tests for those should also be updated.

I'd like that to be done before we start migrating everyone across.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8943240 [details]
Bug 1431069 - allow eslint to deal with ChromeUtils imports,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213568/diff/1-2/

Comment 5

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #3)
> Hmm, so I just realised we should update our other rules as well -
> no-import-into-var-and-global and no-single-arg-cu-import - otherwise we run
> the risk of regressing with ChromeUtils. The tests for those should also be
> updated.
> 
> I'd like that to be done before we start migrating everyone across.

Ah, good points. Done. :-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/046fb034b323
allow eslint to deal with ChromeUtils imports, r=standard8

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/046fb034b323