Closed Bug 1431079 Opened 8 years ago Closed 6 years ago

Crash in MessageLoop::PostTask_Helper called from CompositorManagerParent()

Categories

(Core :: Graphics, defect, P3)

58 Branch
defect

Tracking

()

RESOLVED INACTIVE
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- wontfix
firefox57 --- unaffected
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix

People

(Reporter: philipp, Assigned: aosmond)

Details

(Keywords: crash, regression, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is report bp-52d415c3-081a-4020-8806-70a330180117. ============================================================= Top 10 frames of crashing thread: 0 xul.dll MessageLoop::PostTask_Helper ipc/chromium/src/base/message_loop.cc:375 1 xul.dll mozilla::layers::CompositorManagerParent::Create gfx/layers/ipc/CompositorManagerParent.cpp:65 2 xul.dll mozilla::gfx::GPUProcessManager::CreateContentCompositorManager gfx/ipc/GPUProcessManager.cpp:887 3 xul.dll mozilla::gfx::GPUProcessManager::CreateContentBridges gfx/ipc/GPUProcessManager.cpp:848 4 xul.dll mozilla::dom::ContentParent::InitInternal dom/ipc/ContentParent.cpp:2331 5 xul.dll JS::DispatchTraceKindTyped<TraceManuallyBarrieredEdgeFunctor, JSTracer*&, js::gc::Cell**&, char const*&> js/public/TraceKind.h:196 6 xul.dll mozilla::dom::ContentParent::LaunchSubprocess dom/ipc/ContentParent.cpp:2056 7 xul.dll mozilla::dom::ContentParent::GetNewOrUsedBrowserProcess dom/ipc/ContentParent.cpp:836 8 xul.dll mozilla::dom::ContentParent::CreateBrowser dom/ipc/ContentParent.cpp:1161 9 xul.dll nsFrameLoader::TryRemoteBrowser dom/base/nsFrameLoader.cpp:3230 ============================================================= crashes with similar stack traces during application shutdown are starting to show up since firefox 58. Correlations for Firefox Beta (83.47% in signature vs 00.19% overall) GFX_ERROR "Attempting to post to a invalid Compositor Loop" = true (59.50% in signature vs 00.09% overall) address = 0x44 (38.84% in signature vs 00.14% overall) address = 0x80
Looks like we tried to spawn a new content process after shutdown was observed.
ContentParent::InitInternal / setting up the content bridges is supposed to be an infallible operation, but we shutdown the compositor thread earlier than ContentParent does it seems. It relies upon the shutdown of the layout module itself which comes in much later. Changing InitInternal to be fallible seems a bit late in the process to make the decision however, so ContentParent::CreateBrowser should probably abort if shutdown has been initiated.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [gfx-noted]
Attachment #8943970 - Flags: review?(bugs) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/49ff2faf3b6b Ensure we don't attempt to launch content processes during shutdown. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Please request Beta approval on this. We may want to keep an eye on the Fx58 crash rate as well for possible dot release inclusion.
Flags: needinfo?(aosmond)
This didn't fix it (and I see why -- so obvious now, very silly of me). Also, I also see more variants of the signature which are troubling me / need investigation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
moving 60 status back to affected per comment 8.
Target Milestone: mozilla60 → ---
Andrew, any chance you'll be returning to this bug soon?
Only a few crashes in beta 62 and moderate (~600/week) on release. Andrew did you intend to follow up here? From comment 8 it looks like you may have intended to.
From email discussion, Andrew says that outreach to Microsoft is in progress.
Andrew, did you get any feedback from Microsoft that would help us progress on this bug?
Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.
Crash Signature: [@ MessageLoop::PostTask_Helper] → [@ MessageLoop::PostTask_Helper] [@ MessageLoop::PostTask_Helper | MessageLoop::PostTask | mozilla::layers::CompositorManagerParent::Create]

This is very low volume now among older releases, especially the traces containing CompositorManagerParent. I don't see anything for 69+.

Status: REOPENED → RESOLVED
Closed: 8 years ago → 6 years ago
Flags: needinfo?(aosmond)
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: