Apparently the following is no longer true: # # This is the group your web server runs on. # If you have a windows box, ignore this setting. # If you do not wish for checksetup to adjust the permissions of anything, # set this to "". # If you set this to anything besides "", you will need to run checksetup.pl # as root. $webservergroup = ""; Yet that is what it still said in my localconfig after I updated.
This is not really a docs issue. Moving to Bugzilla-General. 2.16 issue - a comment tidyup? Gerv
Assignee: mbarnson → justdave
Component: Documentation → Bugzilla-General
Target Milestone: --- → Bugzilla 2.16
The text in checksetup has changed, but that won't affect the stuff already in localconfig, since its not a new variable...
So people upgrading will have localconfig files whose comments are incorrect? Is there any way we can fix this? Gerv
We make this a docs issue, I guess. There aren't any delimeters - we just check if the var is defined. The only way to force a comment change would be to rename the variable, which would add a new comment. It wouldn't delete the old one, though.
Or, we could add code to change the comment...
Long term it might be a good idea to get checksetup.pl to read in localconfig and rewrite it with the current comments? We would need to add a comment to the top that any comment changes will get lost, and we should release note it, however. Whether this is too much for 2.16, I'm not sure.
I suppose if we found an exact match on the comment, we could change it. However, people may have there own comments in localconfig. In any event, I dont think this is a 2.16 issue at this stage.
I'd say the ability to keep comments up to date far outweighs the ability to add comments to localconfig.
Lets fix the comment for new installs to be accurate. If people want the latest and greatest comments they can blow away localconfig and recreate it. I agree it would be best if checksetup.pl were to read in and re-write the entire file with the current comments every time it ran, but That's Another Bug (bug 147776, in fact). Let's just fix the issue at hand here.
Keywords: patch, review
Whiteboard: want for 2.16rc2
Comment on attachment 85386 [details] [diff] [review] patch Although this is not totally accurate either, it does convey the right message ("set your webservergroup || die"). r=jouni
HEAD: Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.153; previous revision: 1.152 done BUGZILLA-2_16-BRANCH: Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 184.108.40.206; previous revision: 220.127.116.11 done
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.