143108 - localconfig says that $webservergroup = "" will prevent permission changes

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Hixie (not reading bugmail)]

Apparently the following is no longer true:


#
# This is the group your web server runs on.
# If you have a windows box, ignore this setting.
# If you do not wish for checksetup to adjust the permissions of anything,
# set this to "".
# If you set this to anything besides "", you will need to run checksetup.pl
# as root.
$webservergroup = "";


Yet that is what it still said in my localconfig after I updated.

Comment 1

[Gervase Markham [:gerv]]

This is not really a docs issue. Moving to Bugzilla-General. 2.16 issue - a
comment tidyup?

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

The text in checksetup has changed, but that won't affect the stuff already in
localconfig, since its not a new variable...

Comment 3

[Gervase Markham [:gerv]]

So people upgrading will have localconfig files whose comments are incorrect?

Is there any way we can fix this?

Gerv

Comment 4

[Bradley Baetz (:bbaetz)]

We make this a docs issue, I guess. There aren't any delimeters - we just check
if the var is defined. The only way to force a comment change would be to rename
the variable, which would add a new comment. It wouldn't delete the old one, though.

Comment 5

[Hixie (not reading bugmail)]

Or, we could add code to change the comment...

Comment 6

[Matthew Tuck [:CodeMachine]]

Long term it might be a good idea to get checksetup.pl to read in localconfig
and rewrite it with the current comments?  We would need to add a comment to the
top that any comment changes will get lost, and we should release note it, however.

Whether this is too much for 2.16, I'm not sure.

Comment 7

[Bradley Baetz (:bbaetz)]

I suppose if we found an exact match on the comment, we could change it.
However, people may have there own comments in localconfig.

In any event, I dont think this is a 2.16 issue at this stage.

Comment 8

[Matthew Tuck [:CodeMachine]]

I'd say the ability to keep comments up to date far outweighs the ability to add
comments to localconfig.

Comment 9

[Dave Miller [:justdave]]

Attachment: patch

Comment 10

[Dave Miller [:justdave]]

Lets fix the comment for new installs to be accurate.  If people want the latest
and greatest comments they can blow away localconfig and recreate it.

I agree it would be best if checksetup.pl were to read in and re-write the
entire file with the current comments every time it ran, but That's Another Bug
(bug 147776, in fact).  Let's just fix the issue at hand here.

Comment 11

[Jouni Heikniemi]

Comment on attachment 85386 [details] [diff] [review]
patch

Although this is not totally accurate either, it does convey the right message
("set your webservergroup || die").

r=jouni

Comment 12

[Dave Miller [:justdave]]

HEAD:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.153; previous revision: 1.152
done

BUGZILLA-2_16-BRANCH:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.149.2.4; previous revision: 1.149.2.3
done